Implements support for ignoring method type arguments in resolution.

tests/compiler/dart2js/mock_compiler.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mock_compiler;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:compiler/compiler.dart' as api;
 import 'package:compiler/src/common/names.dart' show
     Uris;
 import 'package:compiler/src/constants/expressions.dart';
+import 'package:compiler/src/dart_types.dart' show DartType;
 import 'package:compiler/src/diagnostics/diagnostic_listener.dart';
 import 'package:compiler/src/diagnostics/source_span.dart';
 import 'package:compiler/src/diagnostics/spannable.dart';
 import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/elements/visitor.dart';
 import 'package:compiler/src/js_backend/backend_helpers.dart' show
     BackendHelpers;
 import 'package:compiler/src/js_backend/lookup_map_analysis.dart' show
     LookupMapAnalysis;
 import 'package:compiler/src/io/source_file.dart';
@@ skipping 193 matching lines @@
   }
 
   CollectingTreeElements resolveStatement(String text) {
     parsedTree = parseStatement(text);
     return resolveNodeStatement(parsedTree, new MockElement(mainApp));
   }
 
   TreeElementMapping resolveNodeStatement(Node tree,
                                           ExecutableElement element) {
     ResolverVisitor visitor =
-        new ResolverVisitor(this, element,
+        new ResolverVisitor(
+            this,
+            element,
             new ResolutionRegistry(this,
-                new CollectingTreeElements(element)));
-    if (visitor.scope is LibraryScope) {
+                new CollectingTreeElements(element)),
+            scope: new MockTypeVariablesScope(

[Johnni Winther, 2016/04/29 07:21:06]

Why is this necessary?

[eernst, 2016/04/29 13:24:50]

I managed to remove one of the two usages of this kind of scope (in
`resolverVisitor()`). Removing the other one causes >13 tests to fail in
`tools/test.py --checked --mode=release dart2js`. The reason is that there is a
mock function `function` whose enclosing scope structure differs from the scope
structure of all the functions created in the compiler; it seems reasonable to
stick with the compiler style setup also in the context of mock entities.

+                element.enclosingElement.buildScope()));
+    if (visitor.scope is LibraryScope ||
+        visitor.scope is MockTypeVariablesScope) {
       visitor.scope = new MethodScope(visitor.scope, element);
     }
     visitor.visit(tree);
     visitor.scope = new LibraryScope(element.library);
     return visitor.registry.mapping;
   }
 
   resolverVisitor() {
     Element mockElement = new MockElement(mainApp.entryCompilationUnit);
     ResolverVisitor visitor =
-        new ResolverVisitor(this, mockElement,
-          new ResolutionRegistry(this,
-              new CollectingTreeElements(mockElement)));
+        new ResolverVisitor(
+            this,
+            mockElement,
+            new ResolutionRegistry(
+                this, new CollectingTreeElements(mockElement)),
+            scope: new MockTypeVariablesScope(
+                mockElement.enclosingElement.buildScope()));
     visitor.scope = new MethodScope(visitor.scope, mockElement);
     return visitor;
   }
 
   parseScript(String text, [LibraryElement library]) {
     if (library == null) library = mainApp;
     parseUnit(text, this, library, registerSource);
   }
 
   Future scanBuiltinLibraries() {
@@ skipping 60 matching lines @@
     map.remove(node);
   }
 
   List<ConstantExpression> get constants {
     List<ConstantExpression> list = <ConstantExpression>[];
     forEachConstantNode((_, c) => list.add(c));
     return list;
   }
 }
 
+class MockTypeVariablesScope extends TypeVariablesScope {
+  @override
+  List<DartType> get typeVariables => <DartType>[];
+  MockTypeVariablesScope(Scope parent) : super(parent);
+  String toString() => 'MockTypeVariablesScope($parent)';
+}
+
 // The mock compiler does not split the program in output units.
 class MockDeferredLoadTask extends DeferredLoadTask {
   MockDeferredLoadTask(Compiler compiler) : super(compiler);
 
   OutputUnit getElementOutputUnit(dynamic dependency) {
     return mainOutputUnit;
   }
 }
 
 api.DiagnosticHandler createHandler(MockCompiler compiler, String text,
@@ skipping 52 matching lines @@
       trustTypeAnnotations: trustTypeAnnotations,
       enableTypeAssertions: enableTypeAssertions,
       enableUserAssertions: enableUserAssertions,
       expectedErrors: expectedErrors,
       expectedWarnings: expectedWarnings,
       outputProvider: outputProvider);
   compiler.registerSource(uri, code);
   compiler.diagnosticHandler = createHandler(compiler, code);
   return compiler;
 }