[wasm] Pass byte position for trapping instructions

[wasm] Pass byte position for trapping instructions

During ast decoding and turbofan graph construction, we explicitely pass
the byte offset for all instructions which potentially trap.
The byte offset is finally passed to the runtime function which throws
the actual error, but it is not used there yet.

The WasmGraphBuilder::Binop and Unop methods have a default value of -1
for the position, which allows for more compact code for all the
functions which assemble bigger snippets from the primitive operations.
Whenever the position is actually used for generating a trap, we
check that it is not negative.

R=titzer@chromium.org

Committed: https://crrev.com/bf1797b1d074da7fdd571e7604c33f8466d585ed
Cr-Commit-Position: refs/heads/master@{#35925}

[titzer, 2016-04-28 11:27:00]

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:200: // Create trap code for the first time this
trap is used.
Update comment: s/this trap is used//

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.h
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.h:92: int position = -1);
Let's introduce a typedef to separate normal ints from bytecode offsets. A good
place for that might be wasm-opcodes.h:

typedef int WasmCodePosition;

https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1646: inline int current_position() { return
position(pc_); }
Let's inline this one, since it's not actually shorter than its body.

[Clemens Hammacher, 2016-04-28 12:43:20]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-28 12:43:22]

The CQ bit was unchecked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-28 12:43:28]

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:200: // Create trap code for the first time this
trap is used.
On 2016/04/28 at 11:27:00, titzer wrote:
> Update comment: s/this trap is used//

Done.

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.h
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.h:92: int position = -1);
On 2016/04/28 at 11:27:00, titzer wrote:
> Let's introduce a typedef to separate normal ints from bytecode offsets. A
good place for that might be wasm-opcodes.h:
> 
> typedef int WasmCodePosition;

Done.

https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1646: inline int current_position() { return
position(pc_); }
On 2016/04/28 at 11:27:00, titzer wrote:
> Let's inline this one, since it's not actually shorter than its body.

.. and it just had one usage.
Done.

[titzer, 2016-04-28 12:57:53]

On 2016/04/28 12:43:28, Clemens Hammacher wrote:
>
https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:200: // Create trap code for the first time this
> trap is used.
> On 2016/04/28 at 11:27:00, titzer wrote:
> > Update comment: s/this trap is used//
> 
> Done.
> 
> https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler.h
> File src/compiler/wasm-compiler.h (right):
> 
>
https://codereview.chromium.org/1915123006/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.h:92: int position = -1);
> On 2016/04/28 at 11:27:00, titzer wrote:
> > Let's introduce a typedef to separate normal ints from bytecode offsets. A
> good place for that might be wasm-opcodes.h:
> > 
> > typedef int WasmCodePosition;
> 
> Done.
> 
> https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/1915123006/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:1646: inline int current_position() { return
> position(pc_); }
> On 2016/04/28 at 11:27:00, titzer wrote:
> > Let's inline this one, since it's not actually shorter than its body.
> 
> .. and it just had one usage.
> Done.

lgtm

[Clemens Hammacher, 2016-05-02 08:21:28]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-05-02 08:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1915123006/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-02 08:21:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915123006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915123006/40001

[commit-bot: I haz the power, 2016-05-02 08:47:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 08:48:31]

Description was changed from

==========
[wasm] Pass byte position for trapping instructions

During ast decoding and turbofan graph construction, we explicitely pass
the byte offset for all instructions which potentially trap.
The byte offset is finally passed to the runtime function which throws
the actual error, but it is not used there yet.

The WasmGraphBuilder::Binop and Unop methods have a default value of -1
for the position, which allows for more compact code for all the
functions which assemble bigger snippets from the primitive operations.
Whenever the position is actually used for generating a trap, we
check that it is not negative.

R=titzer@chromium.org
==========

to

==========
[wasm] Pass byte position for trapping instructions

During ast decoding and turbofan graph construction, we explicitely pass
the byte offset for all instructions which potentially trap.
The byte offset is finally passed to the runtime function which throws
the actual error, but it is not used there yet.

The WasmGraphBuilder::Binop and Unop methods have a default value of -1
for the position, which allows for more compact code for all the
functions which assemble bigger snippets from the primitive operations.
Whenever the position is actually used for generating a trap, we
check that it is not negative.

R=titzer@chromium.org

Committed: https://crrev.com/bf1797b1d074da7fdd571e7604c33f8466d585ed
Cr-Commit-Position: refs/heads/master@{#35925}
==========

[commit-bot: I haz the power, 2016-05-02 08:48:32]

Patchset 3 (id:??) landed as
https://crrev.com/bf1797b1d074da7fdd571e7604c33f8466d585ed
Cr-Commit-Position: refs/heads/master@{#35925}