Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915113006: depot_tools: add test_api to infra_paths recipe module (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: add test_api to infra_paths recipe module BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300191

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M recipe_modules/infra_paths/api.py View 2 chunks +5 lines, -0 lines 0 comments Download
M recipe_modules/infra_paths/example.py View 2 chunks +8 lines, -1 line 3 comments Download
M recipe_modules/infra_paths/example.expected/linux.json View 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/infra_paths/example.expected/mac.json View 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/infra_paths/example.expected/win.json View 1 chunk +4 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/test_api.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-26 12:45:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915113006/1
4 years, 7 months ago (2016-04-26 12:45:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 12:48:02 UTC) #6
Michael Achenbach
lgtm with suggestion https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py File recipe_modules/infra_paths/example.py (right): https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py#newcode19 recipe_modules/infra_paths/example.py:19: api.step('path exists', []) Maybe also demonstrate ...
4 years, 7 months ago (2016-04-26 13:22:23 UTC) #8
Paweł Hajdan Jr.
https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py File recipe_modules/infra_paths/example.py (right): https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py#newcode19 recipe_modules/infra_paths/example.py:19: api.step('path exists', []) On 2016/04/26 at 13:22:23, Michael Achenbach ...
4 years, 7 months ago (2016-04-26 13:23:25 UTC) #9
Michael Achenbach
lgtm https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py File recipe_modules/infra_paths/example.py (right): https://codereview.chromium.org/1915113006/diff/1/recipe_modules/infra_paths/example.py#newcode19 recipe_modules/infra_paths/example.py:19: api.step('path exists', []) On 2016/04/26 13:23:25, Paweł Hajdan ...
4 years, 7 months ago (2016-04-26 13:26:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915113006/1
4 years, 7 months ago (2016-04-26 13:27:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300191
4 years, 7 months ago (2016-04-26 13:30:01 UTC) #14
tandrii(chromium)
4 years, 7 months ago (2016-04-26 18:50:30 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1924583002/ by tandrii@chromium.org.

The reason for reverting is: breaks skia bots :(.

Powered by Google App Engine
This is Rietveld 408576698