third_party/WebKit/Source/core/fetch/Resource.cpp - Issue 1915113005: [WeakMemoryCache] Field-Trial: Make Reference from MemoryCache to Resource weak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 1915113005: [WeakMemoryCache] Field-Trial: Make Reference from MemoryCache to Resource weak (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MemoryCache_1b0

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/MemoryCache.cpp ('K') | « third_party/WebKit/Source/core/fetch/MemoryCache.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/Resource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp

index 797393003558096ec18e1e5dbc864c64dfc0c425..b2314cba607b8b999516231d08949cace9b5a7d1 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.cpp

+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp

@@ -33,6 +33,7 @@

#include "core/fetch/ResourceLoader.h"

#include "core/inspector/InstanceCounters.h"

#include "platform/Logging.h"

+#include "platform/RuntimeEnabledFeatures.h"

#include "platform/SharedBuffer.h"

#include "platform/TraceEvent.h"

#include "platform/network/HTTPParsers.h"

@@ -573,6 +574,9 @@ bool Resource::unlock()

if (!memoryCache()->contains(this) || hasClientsOrObservers() || !m_revalidatingRequest.isNull() || !m_loadFinishTime || !isSafeToUnlock())

return false;

+ if (RuntimeEnabledFeatures::doNotUnlockSharedBufferEnabled())

+ return false;

m_data->unlock();

return true;

}