Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1915103002:
Simplify style handling in custom font manager. (Closed)
|
Created:
4 years, 7 months ago by bungeman-skia Modified:
4 years, 7 months ago Reviewers:
mtklein CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSimplify style handling in custom font manager.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915103002
Committed: https://skia.googlesource.com/skia/+/77a8ab25c8e329eb75fec8f690d6efc3ca347e5e
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Simplify style handling in custom font manager. ========== to ========== Simplify style handling in custom font manager. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bungeman@google.com changed reviewers: + mtklein@google.com
Removes code, makes things both simpler and more correct.
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915103002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915103002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-04-26 04:12 UTC
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full Skia committer
lgtm
The CQ bit was checked by bungeman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1915103002/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915103002/20001
Message was sent while issue was closed.
Description was changed from ========== Simplify style handling in custom font manager. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify style handling in custom font manager. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/77a8ab25c8e329eb75fec8f690d6efc3ca347e5e ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/77a8ab25c8e329eb75fec8f690d6efc3ca347e5e |
