Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2673)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java

Issue 1915083002: [Android,MediaFling] Create and register the notification object early (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix notification not hiding Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
index dc10f6f68bf163b2c4166327d7f42ce2360592c9..ad2e3a06d3f7ab1552e101f92ca4d7f0f9555538 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
@@ -256,6 +256,7 @@ public class DefaultMediaRouteController extends AbstractMediaRouteController {
configureNewSession(data);
mPreferredTitle = preferredTitle;
+ updateTitle(mPreferredTitle);
mStartPositionMillis = startPositionMillis;
// Make sure we get a session status. If the session becomes active
// immediately then the broadcast session status can arrive before we have
@@ -562,7 +563,7 @@ public class DefaultMediaRouteController extends AbstractMediaRouteController {
*/
protected void onActivitiesDestroyed() {
ApplicationStatus.unregisterApplicationStateListener(mApplicationStateListener);
- disconnect();
+ release();
}
/**
@@ -633,7 +634,7 @@ public class DefaultMediaRouteController extends AbstractMediaRouteController {
if (statusBundle.containsKey(MediaControlIntent.EXTRA_ITEM_METADATA)) {
Bundle metadataBundle =
(Bundle) statusBundle.getParcelable(MediaControlIntent.EXTRA_ITEM_METADATA);
- updateTitle(metadataBundle.getString(MediaItemMetadata.KEY_TITLE));
+ updateTitle(metadataBundle.getString(MediaItemMetadata.KEY_TITLE, mPreferredTitle));
}
// Extract the item status, if available.

Powered by Google App Engine
This is Rietveld 408576698