Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: tools/build_command_buffer.py

Issue 1915063002: build_command_buffer: Don't 'git checkout' when --no-sync (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build_command_buffer.py
diff --git a/tools/build_command_buffer.py b/tools/build_command_buffer.py
index 88748d678921885d923f4ef3b4725ccb1c3fc000..ee325878d446a4e7ee053464f6de4ed3029fced7 100755
--- a/tools/build_command_buffer.py
+++ b/tools/build_command_buffer.py
@@ -114,14 +114,13 @@ def main():
sys.exit('Error (ret code: %s) calling "%s" in %s' % (error.returncode,
error.cmd, chrome_src_dir))
- try:
- subprocess.check_call(['git', 'checkout', args.chrome_revision],
- cwd=chrome_src_dir)
- except subprocess.CalledProcessError as error:
- sys.exit('Error (ret code: %s) calling "%s" in %s' % (error.returncode,
- error.cmd, chrome_src_dir))
+ try:
+ subprocess.check_call(['git', 'checkout', args.chrome_revision],
+ cwd=chrome_src_dir)
+ except subprocess.CalledProcessError as error:
+ sys.exit('Error (ret code: %s) calling "%s" in %s' % (error.returncode,
+ error.cmd, chrome_src_dir))
- if not args.no_sync:
try:
os.environ['GYP_GENERATORS'] = 'ninja'
subprocess.check_call([gclient, 'sync', '--reset', '--force'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698