Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1915053002:
Remove thread DCHECK from RegisterAwGLFunctor (Closed)
|
Created:
4 years, 8 months ago by Tobias Sargeant Modified:
4 years, 8 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org, Torne Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove thread DCHECK from RegisterAwGLFunctor
BUG=597167
NOTRY=true
Committed: https://crrev.com/161c8946c7474131ed93447dec861bb4c70a0b81
Cr-Commit-Position: refs/heads/master@{#389481}
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 ========== to ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 ==========
tobiasjs@chromium.org changed reviewers: + boliu@chromium.org
This is a bit of a worry. The DCHECK here made it past the commit queue; but the whole unittest test suite crashes, and 0 of 0 tests run: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
torne@chromium.org changed reviewers: + torne@chromium.org
lgtm
The CQ bit was checked by tobiasjs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915053002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by tobiasjs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915053002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
Re-opened crbug.com/585585 It's ok to use NOTRY=true for the chromium bot failures, since android bots are green already, and this can't possibly affect the desktop bots.
Description was changed from ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 ========== to ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 NOTRY=true ==========
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by tobiasjs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915053002/1
Message was sent while issue was closed.
Description was changed from ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 NOTRY=true ========== to ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 NOTRY=true ========== to ========== Remove thread DCHECK from RegisterAwGLFunctor BUG=597167 NOTRY=true Committed: https://crrev.com/161c8946c7474131ed93447dec861bb4c70a0b81 Cr-Commit-Position: refs/heads/master@{#389481} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/161c8946c7474131ed93447dec861bb4c70a0b81 Cr-Commit-Position: refs/heads/master@{#389481}
Message was sent while issue was closed.
what was different in PS2?
Message was sent while issue was closed.
On 2016/04/25 15:34:32, boliu wrote: > what was different in PS2? Nothing at all. Was identical. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
