Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1915033008:
Skip es6/typedarray-copywithin for ignition (Closed)
|
Created:
4 years, 7 months ago by Yang Modified:
4 years, 7 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionSkip es6/typedarray-copywithin for ignition
R=machenbach@chromium.org
BUG=v8:4961
NOTRY=true
LOG=N
NOTREECHECKS=true
Committed: https://crrev.com/cd3a5ee951cebf6b741b2a54983a141c6f164244
Cr-Commit-Position: refs/heads/master@{#35842}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 LOG=N ========== to ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N ==========
lgtm
Description was changed from ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N ========== to ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N NOTREECHECKS=true ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915033008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915033008/1
The CQ bit was unchecked by machenbach@chromium.org
https://codereview.chromium.org/1915033008/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1915033008/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:771: # TODO(yangguo, 4961): test failure with GC stress Could of course add 'es6/typedarray-copywithin': [PASS, ['gc_stress', SKIP]],
https://codereview.chromium.org/1915033008/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1915033008/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:771: # TODO(yangguo, 4961): test failure with GC stress On 2016/04/28 07:27:59, Michael Achenbach wrote: > Could of course add > 'es6/typedarray-copywithin': [PASS, ['gc_stress', SKIP]], or use gc_stress section with ignition below
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1915033008/#ps20001 (title: "address comment")
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915033008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915033008/20001
Message was sent while issue was closed.
Description was changed from ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N NOTREECHECKS=true ========== to ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N NOTREECHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N NOTREECHECKS=true ========== to ========== Skip es6/typedarray-copywithin for ignition R=machenbach@chromium.org BUG=v8:4961 NOTRY=true LOG=N NOTREECHECKS=true Committed: https://crrev.com/cd3a5ee951cebf6b741b2a54983a141c6f164244 Cr-Commit-Position: refs/heads/master@{#35842} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cd3a5ee951cebf6b741b2a54983a141c6f164244 Cr-Commit-Position: refs/heads/master@{#35842} |
