Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 191503002: NaCl: Remove PNaCl's IRT interface whitelist from the PNaCl IRT shims (Closed)

Created:
6 years, 9 months ago by Mark Seaborn
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Remove PNaCl's IRT interface whitelist from the PNaCl IRT shims Disabling various IRT interfaces under PNaCl is now done in the NaCl repo by irt_interfaces.c, as long as pnacl_mode is set to true in nacl_listener.cc. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3803 TEST=PnaclExceptionHandlingDisabled, PnaclDyncodeSyscallDisabled R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255799

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Patch Set 3 : Cherry pick part of https://codereview.chromium.org/164373010/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -74 lines) Patch
M components/nacl/loader/nacl_listener.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c View 1 2 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mark Seaborn
6 years, 9 months ago (2014-03-07 20:47:39 UTC) #1
jvoung (off chromium)
https://codereview.chromium.org/191503002/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right): https://codereview.chromium.org/191503002/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c#newcode11 ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:11: #include "native_client/src/untrusted/irt/irt_dev.h" no need for irt_dev.h anymore either?
6 years, 9 months ago (2014-03-07 21:03:43 UTC) #2
Mark Seaborn
https://codereview.chromium.org/191503002/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right): https://codereview.chromium.org/191503002/diff/1/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c#newcode11 ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:11: #include "native_client/src/untrusted/irt/irt_dev.h" On 2014/03/07 21:03:43, jvoung (cr) wrote: > ...
6 years, 9 months ago (2014-03-07 21:46:13 UTC) #3
jvoung (off chromium)
lgtm
6 years, 9 months ago (2014-03-07 21:49:52 UTC) #4
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 9 months ago (2014-03-08 00:41:59 UTC) #5
Mark Seaborn
The CQ bit was unchecked by mseaborn@chromium.org
6 years, 9 months ago (2014-03-08 07:20:14 UTC) #6
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 9 months ago (2014-03-08 18:28:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/191503002/40001
6 years, 9 months ago (2014-03-08 18:28:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 19:34:56 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234534
6 years, 9 months ago (2014-03-08 19:34:57 UTC) #10
Mark Seaborn
Committed patchset #3 manually as r255799 (presubmit successful).
6 years, 9 months ago (2014-03-08 23:08:48 UTC) #11
Mark Seaborn
6 years, 9 months ago (2014-03-09 01:08:50 UTC) #12
Message was sent while issue was closed.
I'd forgotten that the "pnacl_mode = 1" change this requires from your change
wasn't committed yet, Jan.  Since that change was being rejected by the CQ, I
cherry-picked that fragment into this change.

Powered by Google App Engine
This is Rietveld 408576698