Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1915003002: Fix abort-on-changestate-headers-received.html so it passes (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix abort-on-changestate-headers-received.html so it passes BUG=585328 Committed: https://crrev.com/5f2fd849368fc9e811e1f6a5fb1215232ec5f79f Cr-Commit-Position: refs/heads/master@{#389725}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/js-test.js View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915003002/20001
4 years, 8 months ago (2016-04-26 06:48:37 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 07:48:54 UTC) #4
keishi
Looks like the test was failing because GCController.collectAll wasn't collecting all garbage.
4 years, 8 months ago (2016-04-26 07:55:26 UTC) #7
haraken
LGTM
4 years, 8 months ago (2016-04-26 07:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915003002/20001
4 years, 8 months ago (2016-04-26 08:11:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 08:15:41 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 08:16:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f2fd849368fc9e811e1f6a5fb1215232ec5f79f
Cr-Commit-Position: refs/heads/master@{#389725}

Powered by Google App Engine
This is Rietveld 408576698