extensions/common/api/app_window.idl - Issue 1914993002: Enhance chrome.app.window API with better shelf integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/app_window.idl

Issue 1914993002: Enhance chrome.app.window API with better shelf integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browsertest: Close windows in other order Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/api/app_window.idl

diff --git a/extensions/common/api/app_window.idl b/extensions/common/api/app_window.idl

index f75978ec2688f6bf9c394d7e99f461214023fdd8..105b4a3afcbcab08d025740eaad769e1f81a525d 100644

--- a/extensions/common/api/app_window.idl

+++ b/extensions/common/api/app_window.idl

@@ -225,6 +225,10 @@ namespace app.window {

// Requires the <code>app.window.ime</code> API permission.

[nodoc] boolean? ime;

+ // If true, the window will have its own icon in the shelf instead of being

+ // folded in the menu of the parent app. Defaults to false.

stevenjb 2016/04/26 16:30:01 Use the comment I suggested previously (or somethi

Andra Paraschiv 2016/04/28 09:49:03 Done.

+ boolean? showInShelf;

// Frame type: <code>none</code> or <code>chrome</code> (defaults to

// <code>chrome</code>). For <code>none</code>, the

// <code>-webkit-app-region</code> CSS property can be used to apply

« extensions/browser/app_window/app_window.cc ('K') | « extensions/browser/app_window/app_window_interactive_uitest.cc ('k') | no next file » | no next file with comments »