Enhance chrome.app.window API with better shelf integration

chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 
 #include <stddef.h>
 
 #include "ash/ash_switches.h"
 #include "ash/shelf/shelf.h"
@@ skipping 1474 matching lines @@
   TestEvent click_event(ui::ET_MOUSE_PRESSED);
   item_controller->ItemSelected(click_event);
   EXPECT_TRUE(panel->GetBaseWindow()->IsActive());
   EXPECT_EQ(ash::STATUS_ACTIVE, item.status);
 
   // Active windows don't show attention.
   panel->GetNativeWindow()->SetProperty(aura::client::kDrawAttentionKey, true);
   EXPECT_EQ(ash::STATUS_ACTIVE, item.status);
 }
 
+IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, ShowInShelfWindows) {
+  ash::ShelfModel* shelf_model = ash::Shell::GetInstance()->shelf_model();
+
+  // Test 1

[stevenjb, 2016/04/26 16:30:00]

Describe what each part of this test is testing for instead of 'Test 1', etc.

[Valentin Ilie, 2016/04/28 09:40:09]

Done.

+  int item_count = shelf_model->item_count();
+  const Extension* extension = LoadAndLaunchPlatformApp("launch", "Launched");
+  AppWindow::CreateParams params;
+  params.show_in_shelf = true;
+  AppWindow* window1 =
+      CreateAppWindowFromParams(browser()->profile(), extension, params);
+  // There should be only 1 item added to the shelf.
+  item_count++;

[stevenjb, 2016/04/26 16:30:00]

nit: instead of incrementing item_count here and below, this would be a little
more readable as: EXPECT_EQ(item_count + 1, ...)

[Valentin Ilie, 2016/04/28 09:40:09]

Done.

+  EXPECT_EQ(item_count, shelf_model->item_count());
+  CloseAppWindow(window1);
+
+  // Test 2
+  item_count = shelf_model->item_count();
+  extension = LoadAndLaunchPlatformApp("launch", "Launched");
+
+  params.show_in_shelf = false;
+  window1 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  params.show_in_shelf = true;
+  AppWindow* window2 =
+      CreateAppWindowFromParams(browser()->profile(), extension, params);
+  // There should be 2 items added to the shelf: although window1 has
+  // show_in_shelf set to false, it's the first window created so its icon must
+  // show up in shelf.
+  item_count += 2;
+  EXPECT_EQ(item_count, shelf_model->item_count());
+  CloseAppWindow(window1);
+  CloseAppWindow(window2);
+
+  // Test 3
+  item_count = shelf_model->item_count();
+  extension = LoadAndLaunchPlatformApp("launch", "Launched");
+
+  params.show_in_shelf = false;
+  window1 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  // There should be 1 item added to the shelf: although show_in_shelf is false,
+  // this is the first window created.
+  item_count++;
+  EXPECT_EQ(item_count, shelf_model->item_count());
+  CloseAppWindow(window1);
+
+  // Test 4
+  item_count = shelf_model->item_count();
+
+  extension = LoadAndLaunchPlatformApp("launch", "Launched");
+
+  params.show_in_shelf = true;
+  window1 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  params.show_in_shelf = false;
+  window2 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  // There should be 1 item added to the shelf.
+  item_count += 1;

[stevenjb, 2016/04/26 16:30:00]

This seems incorrect. In the second test, 2 items are created. The creation
order shouldn't matter. window 2 should be associated with the "default" icon
and window 1 should have a separate item.

[Valentin Ilie, 2016/04/28 09:40:09]

We should decide the appropriate behavior here.

+  EXPECT_EQ(item_count, shelf_model->item_count());
+  CloseAppWindow(window1);

[stevenjb, 2016/04/26 16:30:00]

We should also test that the shelf item(s) go away when they are supposed to.
e.g. after every CloseAppWindow we should test item_count. 

[Valentin Ilie, 2016/04/28 09:40:09]

Done.

+  CloseAppWindow(window2);
+
+  // Test 5
+  item_count = shelf_model->item_count();
+
+  extension = LoadAndLaunchPlatformApp("launch", "Launched");
+  params.show_in_shelf = false;
+  window1 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  params.show_in_shelf = false;
+  window2 = CreateAppWindowFromParams(browser()->profile(), extension, params);
+  params.show_in_shelf = true;
+  AppWindow* window3 =
+      CreateAppWindowFromParams(browser()->profile(), extension, params);
+  params.show_in_shelf = true;
+  AppWindow* window4 =
+      CreateAppWindowFromParams(browser()->profile(), extension, params);
+  // There should be 3 item added to the shelf.

[stevenjb, 2016/04/26 16:30:00]

s/item/items/

[Valentin Ilie, 2016/04/28 09:40:09]

Done.

+  item_count += 3;
+  EXPECT_EQ(item_count, shelf_model->item_count());
+  // Any window close order should be valid
+  CloseAppWindow(window4);
+  CloseAppWindow(window1);
+  CloseAppWindow(window3);
+  CloseAppWindow(window2);
+}
+
 // Checks that the browser Alt "tabbing" is properly done.
 IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
                        AltNumberBrowserTabbing) {
   // Get the number of items in the browser menu.
   EXPECT_EQ(0u, chrome::GetTotalBrowserCount());
   // The first activation should create a browser at index 1 (App List @ 0).
   shelf_->ActivateShelfItem(1);
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   // A second activation should not create a new instance.
   shelf_->ActivateShelfItem(1);
@@ skipping 727 matching lines @@
   controller_->ActivateApp(bookmark_app->id(), ash::LAUNCH_FROM_APP_LIST, 0);
 
   // There should be two new browsers.
   EXPECT_EQ(3u, chrome::GetBrowserCount(browser()->profile()));
 
   // The apps should now be running, with the last opened app active.
   EXPECT_EQ(ash::STATUS_RUNNING, model_->ItemByID(hosted_app_shelf_id)->status);
   EXPECT_EQ(ash::STATUS_ACTIVE,
             model_->ItemByID(bookmark_app_shelf_id)->status);
 }