Enhance chrome.app.window API with better shelf integration

extensions/browser/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/app_window/app_window_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 57 matching lines @@
 const char kImeOptionIsNotSupported[] =
     "The \"ime\" option is not supported for platform app.";
 #if !defined(OS_CHROMEOS)
 const char kImeWindowUnsupportedPlatform[] =
     "The \"ime\" option can only be used on ChromeOS.";
 #else
 const char kImeWindowMustBeImeWindowOrPanel[] =
     "IME extensions must create ime window ( with \"ime: true\" and "
     "\"frame: 'none'\") or panel window (with \"type: panel\").";
 #endif
+const char kShowInShelfWindowKeyNotSet[] =
+    "The showInShelf=true window property requires window id to be set.";

[Reilly Grant (use Gerrit), 2016/07/06 19:53:00]

"The \"showInShelf\" option requires the \"id\" option to be set."

[stevenjb, 2016/07/07 22:55:54]

See my other comment, I realized this is not strictly true except for pinning
purposes. That said, for simplicity's sake this is probably fine to enforce.

[Andra Paraschiv, 2016/07/08 07:20:27]

Yes, as Steven mentioned before, the pinning needs an unique id for each window
shown in shelf. Otherwise, if we only open the showInShelf=true window without
pinning, the legacy app_shelf_id can be used.

 }  // namespace app_window_constants
 
 const char kNoneFrameOption[] = "none";
 
 namespace {
 
 // If the same property is specified for the inner and outer bounds, raise an
 // error.
 bool CheckBoundsConflict(const std::unique_ptr<int>& inner_property,
                          const std::unique_ptr<int>& outer_property,
@@ skipping 226 matching lines @@
     }
 
     if (options->focused.get())
       create_params.focused = *options->focused.get();
 
     if (options->visible_on_all_workspaces.get()) {
       create_params.visible_on_all_workspaces =
           *options->visible_on_all_workspaces.get();
     }
 
+    if (options->show_in_shelf.get()) {
+      create_params.show_in_shelf = *options->show_in_shelf.get();
+
+      if (create_params.show_in_shelf == true &&

[Reilly Grant (use Gerrit), 2016/07/06 19:53:00]

Don't check booleans with == true.

[Andra Paraschiv, 2016/07/08 07:20:27]

Done.

+          create_params.window_key.empty()) {
+        error_ = app_window_constants::kShowInShelfWindowKeyNotSet;
+        return false;
+      }
+    }
+
     if (options->type != app_window::WINDOW_TYPE_PANEL) {
       switch (options->state) {
         case app_window::STATE_NONE:
         case app_window::STATE_NORMAL:
           break;
         case app_window::STATE_FULLSCREEN:
           create_params.state = ui::SHOW_STATE_FULLSCREEN;
           break;
         case app_window::STATE_MAXIMIZED:
           create_params.state = ui::SHOW_STATE_MAXIMIZED;
@@ skipping 219 matching lines @@
 
   if (options.frame->as_frame_options->inactive_color.get()) {
     error_ = app_window_constants::kInactiveColorWithoutColor;
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions