Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1914973002: Reinsert (and test) handling of exceptions from user code. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index bc7dfe0e3982787e6b721aac2a3806c6eb67e300..0ea3e15846ef91cffcfe9458e2c397abeab2adfb 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -1056,8 +1056,9 @@ abstract class Compiler implements LibraryLoaderListener {
void reportDiagnostic(DiagnosticMessage message,
List<DiagnosticMessage> infos, api.Diagnostic kind);
+
ahe 2016/04/25 10:13:33 Extra line.
Johnni Winther 2016/04/25 10:33:24 Done.
void reportCrashInUserCode(String message, exception, stackTrace) {
- _reporter.onCrashInUserCode(message, exception, stackTrace);
+ reporter.onCrashInUserCode(message, exception, stackTrace);
}
/// Messages for which compile-time errors are reported but compilation
@@ -1771,6 +1772,7 @@ class _CompilerDiagnosticReporter extends DiagnosticReporter {
throw error;
}
+ @override
void onCrashInUserCode(String message, exception, stackTrace) {
hasCrashed = true;
print('$message: ${tryToString(exception)}');

Powered by Google App Engine
This is Rietveld 408576698