Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1914973002: Reinsert (and test) handling of exceptions from user code. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reinsert (and test) handling of exceptions from user code. Closes issue #26304 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/09c242e729de2e488cd36960fe2a4a882421086c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -13 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +21 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 1 chunk +11 lines, -1 line 0 comments Download
M tests/compiler/dart2js/diagnostic_helper.dart View 1 chunk +0 lines, -5 lines 0 comments Download
A tests/compiler/dart2js/user_crash_test.dart View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-25 08:52:34 UTC) #2
ahe
lgtm https://codereview.chromium.org/1914973002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1914973002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1059 pkg/compiler/lib/src/compiler.dart:1059: Extra line. https://codereview.chromium.org/1914973002/diff/1/tests/compiler/dart2js/user_crash_test.dart File tests/compiler/dart2js/user_crash_test.dart (right): https://codereview.chromium.org/1914973002/diff/1/tests/compiler/dart2js/user_crash_test.dart#newcode97 tests/compiler/dart2js/user_crash_test.dart:97: ...
4 years, 8 months ago (2016-04-25 10:13:33 UTC) #3
Johnni Winther
https://codereview.chromium.org/1914973002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1914973002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1059 pkg/compiler/lib/src/compiler.dart:1059: On 2016/04/25 10:13:33, ahe wrote: > Extra line. Done. ...
4 years, 8 months ago (2016-04-25 10:33:25 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-04-25 10:56:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
09c242e729de2e488cd36960fe2a4a882421086c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698