Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1914963002: Introduce v8-cache-strategies-for-cache-storage setting flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 "online-check-only" } 401 "online-check-only" }
402 }; 402 };
403 403
404 const FeatureEntry::Choice kV8CacheOptionsChoices[] = { 404 const FeatureEntry::Choice kV8CacheOptionsChoices[] = {
405 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 405 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
406 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kV8CacheOptions, "none" }, 406 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kV8CacheOptions, "none" },
407 { IDS_FLAGS_V8_CACHE_OPTIONS_PARSE, switches::kV8CacheOptions, "parse" }, 407 { IDS_FLAGS_V8_CACHE_OPTIONS_PARSE, switches::kV8CacheOptions, "parse" },
408 { IDS_FLAGS_V8_CACHE_OPTIONS_CODE, switches::kV8CacheOptions, "code" }, 408 { IDS_FLAGS_V8_CACHE_OPTIONS_CODE, switches::kV8CacheOptions, "code" },
409 }; 409 };
410 410
411 const FeatureEntry::Choice kV8CacheStrategiesForCacheStorageChoices[] = {
412 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
413 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
414 switches::kV8CacheStrategiesForCacheStorage, "none"},
415 {IDS_FLAGS_V8_CACHE_STRATEGIES_FOR_CACHE_STORAGE_NORMAL,
416 switches::kV8CacheStrategiesForCacheStorage, "normal"},
417 {IDS_FLAGS_V8_CACHE_STRATEGIES_FOR_CACHE_STORAGE_AGGRESSIVE,
418 switches::kV8CacheStrategiesForCacheStorage, "aggressive"},
419 };
420
411 #if defined(OS_ANDROID) 421 #if defined(OS_ANDROID)
412 const FeatureEntry::Choice kProgressBarAnimationChoices[] = { 422 const FeatureEntry::Choice kProgressBarAnimationChoices[] = {
413 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 423 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
414 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 424 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
415 switches::kProgressBarAnimation, "disabled" }, 425 switches::kProgressBarAnimation, "disabled" },
416 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_LINEAR, 426 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_LINEAR,
417 switches::kProgressBarAnimation, "linear" }, 427 switches::kProgressBarAnimation, "linear" },
418 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_SMOOTH, 428 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_SMOOTH,
419 switches::kProgressBarAnimation, "smooth" }, 429 switches::kProgressBarAnimation, "smooth" },
420 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_SMOOTH_INDETERMINATE, 430 { IDS_FLAGS_PROGRESS_BAR_ANIMATION_SMOOTH_INDETERMINATE,
(...skipping 1077 matching lines...) Expand 10 before | Expand all | Expand 10 after
1498 IDS_FLAGS_TRY_SUPPORTED_CHANNEL_LAYOUTS_NAME, 1508 IDS_FLAGS_TRY_SUPPORTED_CHANNEL_LAYOUTS_NAME,
1499 IDS_FLAGS_TRY_SUPPORTED_CHANNEL_LAYOUTS_DESCRIPTION, kOsWin, 1509 IDS_FLAGS_TRY_SUPPORTED_CHANNEL_LAYOUTS_DESCRIPTION, kOsWin,
1500 SINGLE_VALUE_TYPE(switches::kTrySupportedChannelLayouts)}, 1510 SINGLE_VALUE_TYPE(switches::kTrySupportedChannelLayouts)},
1501 #endif 1511 #endif
1502 #if defined(ENABLE_WEBRTC) 1512 #if defined(ENABLE_WEBRTC)
1503 {"enable-webrtc-dtls12", IDS_FLAGS_WEBRTC_DTLS12_NAME, 1513 {"enable-webrtc-dtls12", IDS_FLAGS_WEBRTC_DTLS12_NAME,
1504 IDS_FLAGS_WEBRTC_DTLS12_DESCRIPTION, kOsAll, 1514 IDS_FLAGS_WEBRTC_DTLS12_DESCRIPTION, kOsAll,
1505 SINGLE_VALUE_TYPE(switches::kEnableWebRtcDtls12)}, 1515 SINGLE_VALUE_TYPE(switches::kEnableWebRtcDtls12)},
1506 #endif 1516 #endif
1507 #if defined(ENABLE_WEBRTC) 1517 #if defined(ENABLE_WEBRTC)
1508 {"enable-webrtc-ecdsa", 1518 {"enable-webrtc-ecdsa", IDS_FLAGS_WEBRTC_ECDSA_NAME,
1509 IDS_FLAGS_WEBRTC_ECDSA_NAME,
1510 IDS_FLAGS_WEBRTC_ECDSA_DESCRIPTION, kOsAll, 1519 IDS_FLAGS_WEBRTC_ECDSA_DESCRIPTION, kOsAll,
1511 FEATURE_VALUE_TYPE(features::kWebRtcEcdsaDefault)}, 1520 FEATURE_VALUE_TYPE(features::kWebRtcEcdsaDefault)},
1512 #endif 1521 #endif
1513 #if defined(OS_MACOSX) 1522 #if defined(OS_MACOSX)
1514 {"app-info-dialog", IDS_FLAGS_APP_INFO_DIALOG_NAME, 1523 {"app-info-dialog", IDS_FLAGS_APP_INFO_DIALOG_NAME,
1515 IDS_FLAGS_APP_INFO_DIALOG_DESCRIPTION, kOsMac, 1524 IDS_FLAGS_APP_INFO_DIALOG_DESCRIPTION, kOsMac,
1516 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAppInfoDialogMac, 1525 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAppInfoDialogMac,
1517 switches::kDisableAppInfoDialogMac)}, 1526 switches::kDisableAppInfoDialogMac)},
1518 {"mac-views-native-app-windows", 1527 {"mac-views-native-app-windows",
1519 IDS_FLAGS_MAC_VIEWS_NATIVE_APP_WINDOWS_NAME, 1528 IDS_FLAGS_MAC_VIEWS_NATIVE_APP_WINDOWS_NAME,
(...skipping 14 matching lines...) Expand all
1534 #endif 1543 #endif
1535 #if defined(OS_CHROMEOS) 1544 #if defined(OS_CHROMEOS)
1536 {"disable-accelerated-mjpeg-decode", 1545 {"disable-accelerated-mjpeg-decode",
1537 IDS_FLAGS_ACCELERATED_MJPEG_DECODE_NAME, 1546 IDS_FLAGS_ACCELERATED_MJPEG_DECODE_NAME,
1538 IDS_FLAGS_ACCELERATED_MJPEG_DECODE_DESCRIPTION, kOsCrOS, 1547 IDS_FLAGS_ACCELERATED_MJPEG_DECODE_DESCRIPTION, kOsCrOS,
1539 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedMjpegDecode)}, 1548 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedMjpegDecode)},
1540 #endif // OS_CHROMEOS 1549 #endif // OS_CHROMEOS
1541 {"v8-cache-options", IDS_FLAGS_V8_CACHE_OPTIONS_NAME, 1550 {"v8-cache-options", IDS_FLAGS_V8_CACHE_OPTIONS_NAME,
1542 IDS_FLAGS_V8_CACHE_OPTIONS_DESCRIPTION, kOsAll, 1551 IDS_FLAGS_V8_CACHE_OPTIONS_DESCRIPTION, kOsAll,
1543 MULTI_VALUE_TYPE(kV8CacheOptionsChoices)}, 1552 MULTI_VALUE_TYPE(kV8CacheOptionsChoices)},
1553 {"v8-cache-strategies-for-cache-storage",
1554 IDS_FLAGS_V8_CACHE_STRATEGIES_FOR_CACHE_STORAGE_NAME,
1555 IDS_FLAGS_V8_CACHE_STRATEGIES_FOR_CACHE_STORAGE_DESCRIPTION, kOsAll,
1556 MULTI_VALUE_TYPE(kV8CacheStrategiesForCacheStorageChoices)},
1544 {"enable-clear-browsing-data-counters", 1557 {"enable-clear-browsing-data-counters",
1545 IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_NAME, 1558 IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_NAME,
1546 IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_DESCRIPTION, kOsAll, 1559 IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_DESCRIPTION, kOsAll,
1547 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableClearBrowsingDataCounters, 1560 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableClearBrowsingDataCounters,
1548 switches::kDisableClearBrowsingDataCounters)}, 1561 switches::kDisableClearBrowsingDataCounters)},
1549 #if defined(ENABLE_TASK_MANAGER) 1562 #if defined(ENABLE_TASK_MANAGER)
1550 {"disable-new-task-manager", IDS_FLAGS_NEW_TASK_MANAGER_NAME, 1563 {"disable-new-task-manager", IDS_FLAGS_NEW_TASK_MANAGER_NAME,
1551 IDS_FLAGS_NEW_TASK_MANAGER_DESCRIPTION, kOsDesktop, 1564 IDS_FLAGS_NEW_TASK_MANAGER_DESCRIPTION, kOsDesktop,
1552 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewTaskManager)}, 1565 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewTaskManager)},
1553 #endif // defined(ENABLE_TASK_MANAGER) 1566 #endif // defined(ENABLE_TASK_MANAGER)
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
1798 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_DESCRIPTION, kOsDesktop, 1811 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_DESCRIPTION, kOsDesktop,
1799 SINGLE_VALUE_TYPE(switches::kEnableGoogleBrandedContextMenu)}, 1812 SINGLE_VALUE_TYPE(switches::kEnableGoogleBrandedContextMenu)},
1800 #endif 1813 #endif
1801 #if defined(OS_MACOSX) 1814 #if defined(OS_MACOSX)
1802 {"enable-fullscreen-in-tab-detaching", 1815 {"enable-fullscreen-in-tab-detaching",
1803 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_NAME, 1816 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_NAME,
1804 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_DESCRIPTION, kOsMac, 1817 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_DESCRIPTION, kOsMac,
1805 SINGLE_VALUE_TYPE(switches::kEnableFullscreenTabDetaching)}, 1818 SINGLE_VALUE_TYPE(switches::kEnableFullscreenTabDetaching)},
1806 #endif 1819 #endif
1807 #if defined(OS_ANDROID) 1820 #if defined(OS_ANDROID)
1808 {"media-style-notification", 1821 {"media-style-notification", IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME,
1809 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME,
1810 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid, 1822 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid,
1811 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)}, 1823 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)},
1812 {"important-sites-in-cbd", 1824 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
1813 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
1814 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid, 1825 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid,
1815 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)}, 1826 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},
1816 #endif 1827 #endif
1817 {"enable-pointer-events", // FLAGS:RECORD_UMA 1828 {"enable-pointer-events", // FLAGS:RECORD_UMA
1818 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME, 1829 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME,
1819 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, 1830 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll,
1820 kOsAll, 1831 FEATURE_VALUE_TYPE(features::kPointerEvents)},
1821 FEATURE_VALUE_TYPE(features::kPointerEvents)},
1822 // NOTE: Adding new command-line switches requires adding corresponding 1832 // NOTE: Adding new command-line switches requires adding corresponding
1823 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1833 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1824 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1834 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1825 }; 1835 };
1826 1836
1827 class FlagsStateSingleton { 1837 class FlagsStateSingleton {
1828 public: 1838 public:
1829 FlagsStateSingleton() 1839 FlagsStateSingleton()
1830 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 1840 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
1831 ~FlagsStateSingleton() {} 1841 ~FlagsStateSingleton() {}
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
2011 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2021 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2012 2022
2013 const FeatureEntry* GetFeatureEntries(size_t* count) { 2023 const FeatureEntry* GetFeatureEntries(size_t* count) {
2014 *count = arraysize(kFeatureEntries); 2024 *count = arraysize(kFeatureEntries);
2015 return kFeatureEntries; 2025 return kFeatureEntries;
2016 } 2026 }
2017 2027
2018 } // namespace testing 2028 } // namespace testing
2019 2029
2020 } // namespace about_flags 2030 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698