third_party/WebKit/Source/core/css/SelectorChecker.cpp - Issue 1914933003: output should not match to :enabled or :disabled pseudo classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1914933003: output should not match to :enabled or :disabled pseudo classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/pseudo-enabled-disabled-output-element.html ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/SelectorChecker.cpp

diff --git a/third_party/WebKit/Source/core/css/SelectorChecker.cpp b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

index c5d4b4d515eda624e7418022b8cb6f4f8eaf742e..3ddf5a3e8e93adef6322f4ede9e04bc1eda364fc 100644

--- a/third_party/WebKit/Source/core/css/SelectorChecker.cpp

+++ b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

@@ -823,7 +823,7 @@ bool SelectorChecker::checkPseudoClass(const SelectorCheckingContext& context, M

return true;

return element.active();

case CSSSelector::PseudoEnabled:

- if (element.isFormControlElement() || isHTMLOptionElement(element) || isHTMLOptGroupElement(element))

+ if (element.matchesEnabledPseudoClass())

tkent 2016/04/25 23:00:12 I meant the code should be just |return element.ma

ramya.v 2016/04/26 05:27:00 Done. Since HTMLAreaElement inherits from HTMLAnch

return !element.isDisabledFormControl();

if (isHTMLAnchorElement(element) || isHTMLAreaElement(element))

return element.isLink();