Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1914933003: output should not match to :enabled or :disabled pseudo classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 m_elementStyle->setUnique(); 816 m_elementStyle->setUnique();
817 element.setChildrenOrSiblingsAffectedByActive(); 817 element.setChildrenOrSiblingsAffectedByActive();
818 } 818 }
819 } 819 }
820 if (!shouldMatchHoverOrActive(context)) 820 if (!shouldMatchHoverOrActive(context))
821 return false; 821 return false;
822 if (InspectorInstrumentation::forcePseudoState(&element, CSSSelector::Ps eudoActive)) 822 if (InspectorInstrumentation::forcePseudoState(&element, CSSSelector::Ps eudoActive))
823 return true; 823 return true;
824 return element.active(); 824 return element.active();
825 case CSSSelector::PseudoEnabled: 825 case CSSSelector::PseudoEnabled:
826 if (element.isFormControlElement() || isHTMLOptionElement(element) || is HTMLOptGroupElement(element)) 826 return element.matchesEnabledPseudoClass();
827 return !element.isDisabledFormControl();
828 if (isHTMLAnchorElement(element) || isHTMLAreaElement(element))
829 return element.isLink();
830 break;
831 case CSSSelector::PseudoFullPageMedia: 827 case CSSSelector::PseudoFullPageMedia:
832 return element.document().isMediaDocument(); 828 return element.document().isMediaDocument();
833 case CSSSelector::PseudoDefault: 829 case CSSSelector::PseudoDefault:
834 return element.matchesDefaultPseudoClass(); 830 return element.matchesDefaultPseudoClass();
835 case CSSSelector::PseudoDisabled: 831 case CSSSelector::PseudoDisabled:
836 // TODO(esprehn): Why not just always return isDisabledFormControl()? 832 // TODO(esprehn): Why not just always return isDisabledFormControl()?
837 // Can it be true for elements not in the list below? 833 // Can it be true for elements not in the list below?
838 if (element.isFormControlElement() || isHTMLOptionElement(element) || is HTMLOptGroupElement(element)) 834 if (element.isFormControlElement() || isHTMLOptionElement(element) || is HTMLOptGroupElement(element))
839 return element.isDisabledFormControl(); 835 return element.isDisabledFormControl();
840 break; 836 break;
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1143 } 1139 }
1144 1140
1145 bool SelectorChecker::matchesFocusPseudoClass(const Element& element) 1141 bool SelectorChecker::matchesFocusPseudoClass(const Element& element)
1146 { 1142 {
1147 if (InspectorInstrumentation::forcePseudoState(const_cast<Element*>(&element ), CSSSelector::PseudoFocus)) 1143 if (InspectorInstrumentation::forcePseudoState(const_cast<Element*>(&element ), CSSSelector::PseudoFocus))
1148 return true; 1144 return true;
1149 return element.focused() && isFrameFocused(element); 1145 return element.focused() && isFrameFocused(element);
1150 } 1146 }
1151 1147
1152 } // namespace blink 1148 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698