Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1914873002: pathops: Add missing header guards in two files. (Closed)

Created:
4 years, 8 months ago by Dean McNamee
Modified:
4 years, 8 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git/@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

pathops: Add missing header guards in two files. Guards were missing in SkIntersectionHelper.h and SkPathOpsTSect.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914873002 Committed: https://skia.googlesource.com/skia/+/12670eb63b743283cf6f0e6e568c1713756e4006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/pathops/SkIntersectionHelper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Dean McNamee
4 years, 8 months ago (2016-04-25 14:23:43 UTC) #4
caryclark
lgtm
4 years, 8 months ago (2016-04-25 14:36:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914873002/1
4 years, 8 months ago (2016-04-25 14:36:55 UTC) #7
commit-bot: I haz the power
The author deanm@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 8 months ago (2016-04-25 14:36:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914873002/1
4 years, 8 months ago (2016-04-26 17:12:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8111) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
4 years, 8 months ago (2016-04-26 17:13:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914873002/1
4 years, 8 months ago (2016-04-26 20:12:13 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:09:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12670eb63b743283cf6f0e6e568c1713756e4006

Powered by Google App Engine
This is Rietveld 408576698