Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1914793002: WIP: PointerWatcher for systray bubble (Closed)

Created:
4 years, 8 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tdresser+watch_chromium.org, tfarina, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@eventobserver
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: PointerWatcher for systray bubble BUG=599142

Patch Set 1 #

Patch Set 2 : tests, ClickedOutsideBubble #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -69 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/mus/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ash/mus/pointer_watcher_delegate_mus.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A ash/mus/pointer_watcher_delegate_mus.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
A ash/pointer_watcher_delegate.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A ash/pointer_watcher_delegate_aura.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A ash/pointer_watcher_delegate_aura.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M ash/shell.h View 1 4 chunks +6 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/system/chromeos/session/logout_button_tray.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/overview/overview_button_tray.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_event_filter.h View 1 1 chunk +11 lines, -13 lines 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 3 chunks +16 lines, -23 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M components/mus/demo/mus_demo.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/demo/mus_demo.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 3 chunks +24 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 1 5 chunks +131 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 2 chunks +6 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_tree_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/root_window_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/window_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 chunks +29 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 2 5 chunks +9 lines, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 4 chunks +33 lines, -0 lines 0 comments Download
A ui/views/mus/window_manager_connection_unittest.cc View 1 1 chunk +108 lines, -0 lines 0 comments Download
A ui/views/pointer_watcher.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698