third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp - Issue 1914693002: Clamp CSS numbers to float range at parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

Issue 1914693002: Clamp CSS numbers to float range at parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

index 51014658dd27281ffba820e298957ff4838f9008..94484091f7473b8c0f524ce5216a4705999134dd 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp

@@ -41,8 +41,12 @@ CSSParserToken::CSSParserToken(CSSParserTokenType type, double numericValue, Num

, m_numericValueType(numericValueType)

, m_numericSign(sign)

, m_unit(static_cast<unsigned>(CSSPrimitiveValue::UnitType::Number))

- , m_numericValue(numericValue)

{

+ if (!std::isfinite(numericValue)) {

+ m_numericValue = 0.0;

rune 2016/04/25 12:24:29 Shouldn't +/-inf be clamped too? Why is 0 a good

+ } else {

+ m_numericValue = clampTo<float>(numericValue);

+ }

ASSERT(type == NumberToken);

}