build/config/BUILD.gn - Issue 1914673002: Revert of clang/win: Disable precompiled headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1914673002: Revert of clang/win: Disable precompiled headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index e863459caaee56c0e0cc81fd5fb8d1d264e554c4..d4caba48a9987fcfd056330277e0df2b2c86ed9d 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -438,8 +438,7 @@

# Recommend precompiled headers for targets with more than 50 .cc files.

config("precompiled_headers") {

if (!is_official_build && !use_goma && !disable_precompiled_headers) {

- # TODO(thakis): Reenable on clang after https://crbug.com/605570 is fixed.

- if (is_win && !is_clang) {

+ if (is_win) {

# This is a string rather than a file GN knows about. It has to match

# exactly what's in the /FI flag below, and what might appear in the

# source code in quotes for an #include directive.

« no previous file with comments | « no previous file | build/win_precompile.gypi » ('j') | no next file with comments »