Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1914673002: Revert of clang/win: Disable precompiled headers. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win: Disable precompiled headers. (patchset #1 id:1 of https://codereview.chromium.org/1904193002/ ) Reason for revert: rnk might have fixed this upstream, let's give it a try :-) Original issue's description: > clang/win: Disable precompiled headers. > > The protobuf3 roll triggered a compiler crash in the pch codepath. > > BUG=605570 > R=hans@chromium.org > > Committed: https://crrev.com/589ef6b6a9d60b21d6c78b92887de1b9d04b7e0f > Cr-Commit-Position: refs/heads/master@{#388887} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605570 Committed: https://crrev.com/8b6d787f07401e9c72a5858a00a396981bbc018d Cr-Commit-Position: refs/heads/master@{#389213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/win_precompile.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of clang/win: Disable precompiled headers.
4 years, 8 months ago (2016-04-22 19:41:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914673002/1
4 years, 8 months ago (2016-04-22 19:41:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 19:42:16 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:51:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b6d787f07401e9c72a5858a00a396981bbc018d
Cr-Commit-Position: refs/heads/master@{#389213}

Powered by Google App Engine
This is Rietveld 408576698