Increase read buffer size for SPDY upload

Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take
into account the new buffer size when zeroing out window size.

BUG=606784
Committed: https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f
Cr-Commit-Position: refs/heads/master@{#389856}

[xunjieli, 2016-04-26 14:46:25]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-04-26 14:46:31]

Patchset #1 (id:20001) has been deleted

[xunjieli, 2016-04-26 14:46:38]

Patchset #1 (id:40001) has been deleted

[xunjieli, 2016-04-26 14:46:43]

Patchset #1 (id:60001) has been deleted

[xunjieli, 2016-04-26 14:49:33]

Description was changed from

==========
Increase read buffer size for SPDY upload

BUG=
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.
==========

[xunjieli, 2016-04-26 14:49:33]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org

[xunjieli, 2016-04-26 14:50:31]

Description was changed from

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.
==========

[xunjieli, 2016-04-26 14:51:58]

Bence, PTAL.  Thank you!

[xunjieli, 2016-04-26 14:55:06]

Description was changed from

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

[xunjieli, 2016-04-26 14:55:38]

Description was changed from

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 to be comparable to the other two implementations.
This will make it easier for net embedders to configure upload to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

[Bence, 2016-04-26 16:59:23]

LGTM with nit.

https://codereview.chromium.org/1914663002/diff/80001/net/spdy/spdy_network_t...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1914663002/diff/80001/net/spdy/spdy_network_t...
net/spdy/spdy_network_transaction_unittest.cc:62: // This currently 16kB.
I think it would be better to remove this comment, because it is especially
prone to becoming out-of-date.

[xunjieli, 2016-04-26 17:03:16]

Thanks a lot for the review, Bence!

https://codereview.chromium.org/1914663002/diff/80001/net/spdy/spdy_network_t...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1914663002/diff/80001/net/spdy/spdy_network_t...
net/spdy/spdy_network_transaction_unittest.cc:62: // This currently 16kB.
On 2016/04/26 16:59:23, Bence wrote:
> I think it would be better to remove this comment, because it is especially
> prone to becoming out-of-date.

Done.

[xunjieli, 2016-04-26 17:03:41]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-04-26 17:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1914663002/#ps100001
(title: "Address Bence's comments")

[commit-bot: I haz the power, 2016-04-26 17:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914663002/100001

[commit-bot: I haz the power, 2016-04-26 18:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:48:00]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xunjieli, 2016-04-26 18:51:23]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:52:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914663002/100001

[commit-bot: I haz the power, 2016-04-26 19:47:57]

Description was changed from

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

[commit-bot: I haz the power, 2016-04-26 19:47:58]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-04-26 19:50:18]

Description was changed from

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for 
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take 
into account the new buffer size when zeroing out window size.

BUG=606784
==========

to

==========
Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take
into account the new buffer size when zeroing out window size.

BUG=606784

Committed: https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f
Cr-Commit-Position: refs/heads/master@{#389856}
==========

[commit-bot: I haz the power, 2016-04-26 19:50:19]

Patchset 2 (id:??) landed as
https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f
Cr-Commit-Position: refs/heads/master@{#389856}