Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1914653002: Make lists in the passwords section aware of the scroll target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.js
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js
index 336b5f40560a777eea9267eb2606d06b915acd88..bf871a4e82014f3338e08e0b7be6922364fc4b20 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js
@@ -18,5 +18,11 @@ Polymer({
type: Object,
notify: true,
},
+
+ /**
+ * The scroll target for the lists in this section.
+ * @type {Element}
michaelpg 2016/10/17 18:59:54 HTMLElement?
hcarmona 2016/10/18 19:33:19 Done.
+ */
+ scrollTarget: HTMLElement,
michaelpg 2016/10/17 18:59:54 shouldn't this just be Object?
hcarmona 2016/10/18 19:33:19 Done.
},
});

Powered by Google App Engine
This is Rietveld 408576698