Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 1914653002: Make lists in the passwords section aware of the scroll target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 25 matching lines...) Expand all
36 toolbarSpinnerActive_: { 36 toolbarSpinnerActive_: {
37 type: Boolean, 37 type: Boolean,
38 value: false, 38 value: false,
39 }, 39 },
40 40
41 /** 41 /**
42 * Dictionary defining page visibility. 42 * Dictionary defining page visibility.
43 * @private {!GuestModePageVisibility} 43 * @private {!GuestModePageVisibility}
44 */ 44 */
45 pageVisibility_: Object, 45 pageVisibility_: Object,
46
47 /**
48 * The scroll target for the lists in this section.
49 * @type {Element}
50 * @private
51 */
52 scrollTarget_: {
53 type: HTMLElement,
54 value: function() {
55 return this.$.headerPanel.scroller;
56 }
57 }
46 }, 58 },
47 59
48 /** @override */ 60 /** @override */
49 created: function() { 61 created: function() {
50 settings.initializeRouteFromUrl(); 62 settings.initializeRouteFromUrl();
51 }, 63 },
52 64
53 /** 65 /**
54 * @override 66 * @override
55 * @suppress {es5Strict} Object literals cannot contain duplicate keys in ES5 67 * @suppress {es5Strict} Object literals cannot contain duplicate keys in ES5
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 onMenuButtonTap_: function() { 133 onMenuButtonTap_: function() {
122 this.$$('app-drawer').toggle(); 134 this.$$('app-drawer').toggle();
123 }, 135 },
124 136
125 /** @private */ 137 /** @private */
126 directionDelegateChanged_: function() { 138 directionDelegateChanged_: function() {
127 this.$$('app-drawer').align = this.directionDelegate.isRtl() ? 139 this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
128 'right' : 'left'; 140 'right' : 'left';
129 }, 141 },
130 }); 142 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698