Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 1914653002: Make lists in the passwords section aware of the scroll target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{about: boolean, basic: boolean, advanced: boolean}} 6 * @typedef {{about: boolean, basic: boolean, advanced: boolean}}
7 */ 7 */
8 var MainPageVisibility; 8 var MainPageVisibility;
9 9
10 /** 10 /**
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 }, 79 },
80 80
81 /** 81 /**
82 * Dictionary defining page visibility. 82 * Dictionary defining page visibility.
83 * @type {!GuestModePageVisibility} 83 * @type {!GuestModePageVisibility}
84 */ 84 */
85 pageVisibility: { 85 pageVisibility: {
86 type: Object, 86 type: Object,
87 value: function() { return {}; }, 87 value: function() { return {}; },
88 }, 88 },
89
90 /**
91 * The scroll target for the lists in this section.
92 * @type {Element}
93 */
94 scrollTarget: HTMLElement,
89 }, 95 },
90 96
91 /** @override */ 97 /** @override */
92 attached: function() { 98 attached: function() {
93 document.addEventListener('toggle-advanced-page', function(e) { 99 document.addEventListener('toggle-advanced-page', function(e) {
94 this.advancedToggleExpanded_ = e.detail; 100 this.advancedToggleExpanded_ = e.detail;
95 this.updatePagesShown_(); 101 this.updatePagesShown_();
96 }.bind(this)); 102 }.bind(this));
97 103
98 var currentRoute = settings.getCurrentRoute(); 104 var currentRoute = settings.getCurrentRoute();
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 371
366 /** 372 /**
367 * @param {(boolean|undefined)} visibility 373 * @param {(boolean|undefined)} visibility
368 * @return {boolean} True unless visibility is false. 374 * @return {boolean} True unless visibility is false.
369 * @private 375 * @private
370 */ 376 */
371 showAdvancedSettings_: function(visibility) { 377 showAdvancedSettings_: function(visibility) {
372 return visibility !== false; 378 return visibility !== false;
373 }, 379 },
374 }); 380 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698