Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1914653002: Make lists in the passwords section aware of the scroll target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-advanced-page' is the settings page containing the advanced 7 * 'settings-advanced-page' is the settings page containing the advanced
8 * settings. 8 * settings.
9 */ 9 */
10 Polymer({ 10 Polymer({
11 is: 'settings-advanced-page', 11 is: 'settings-advanced-page',
12 12
13 behaviors: [SettingsPageVisibility, MainPageBehavior], 13 behaviors: [SettingsPageVisibility, MainPageBehavior],
14 14
15 properties: { 15 properties: {
16 /** Preferences state. */ 16 /** Preferences state. */
17 prefs: { 17 prefs: {
18 type: Object, 18 type: Object,
19 notify: true, 19 notify: true,
20 }, 20 },
21
22 /**
23 * The scroll target for the lists in this section.
24 * @type {Element}
michaelpg 2016/10/17 18:59:54 HTMLElement?
hcarmona 2016/10/18 19:33:19 Done.
25 */
26 scrollTarget: HTMLElement,
michaelpg 2016/10/17 18:59:54 shouldn't this just be Object?
hcarmona 2016/10/18 19:33:19 Done.
21 }, 27 },
22 }); 28 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698