content/browser/web_contents/web_contents_impl.cc - Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (and deal with gfx:: -> display:: rename). Add replication CL as dependent and use its allowfullscreen test file. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/common/frame_messages.h » ('j') | third_party/WebKit/Source/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index e44ae4fe13c652d497333368835aabb7ef3d62f9..d49111a7c3cf46346454da22d8d35649ec03d748 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1866,11 +1866,9 @@ void WebContentsImpl::ExitFullscreenMode(bool will_cause_resize) {

will_cause_resize));

}

+// TODO(alexmos): Remove the unused |render_widget_host| parameter.

bool WebContentsImpl::IsFullscreenForCurrentTab(

RenderWidgetHostImpl* render_widget_host) const {

- if (!RenderViewHostImpl::From(render_widget_host))

- return false;

return delegate_ ? delegate_->IsFullscreenForTabOrPending(this) : false;

}

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/common/frame_messages.h » ('j') | third_party/WebKit/Source/core/dom/Element.cpp » ('J')