Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1914643005: Add support for entering/exiting HTML fullscreen from OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index cc5d4b7645afc52547288c9a68e05182c15ecad1..6e7254a1f588a2724cf6aa1fa6dd4835bad82779 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -194,6 +194,8 @@ void WebFrameWidgetImpl::resizeVisualViewport(const WebSize& newSize)
// to use Page messages. https://crbug.com/599688.
page()->frameHost().visualViewport().setSize(newSize);
page()->frameHost().visualViewport().clampToBoundaries();
+
+ view()->didUpdateFullScreenSize();
alexmos 2016/05/10 21:36:24 This is needed for things like opening/resizing a
}
void WebFrameWidgetImpl::updateMainFrameLayoutSize()
@@ -218,12 +220,12 @@ void WebFrameWidgetImpl::setIgnoreInputEvents(bool newValue)
void WebFrameWidgetImpl::didEnterFullScreen()
{
- // FIXME: Implement full screen for out-of-process iframes.
+ view()->didEnterFullScreen();
}
void WebFrameWidgetImpl::didExitFullScreen()
{
- // FIXME: Implement full screen for out-of-process iframes.
+ view()->didExitFullScreen();
}
void WebFrameWidgetImpl::beginFrame(double lastFrameTimeMonotonic)

Powered by Google App Engine
This is Rietveld 408576698