chrome/renderer/resources/extensions/notifications_custom_bindings.js - Issue 1914643003: [Extensions] Update last_error.js, send_request.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/notifications_custom_bindings.js

Issue 1914643003: [Extensions] Update last_error.js, send_request.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/file_system_custom_bindings.js ('k') | chrome/renderer/resources/extensions/webrtc_desktop_capture_private_custom_bindings.js » ('j') | extensions/renderer/resources/send_request.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/notifications_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/notifications_custom_bindings.js b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

index 4a61d36729b7332619365f6c6dccf24d5eb9ef0f..e793483af2b8c303a36e07cecd7ffb99b256d7f3 100644

--- a/chrome/renderer/resources/extensions/notifications_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

@@ -120,7 +120,7 @@ function genHandle(name, failure_function) {

if (success) {

sendRequest(that.name,

[id, notification_details, callback],

- that.definition.parameters, {stack: stack});

+ that.definition.parameters, {__proto__: null, stack: stack});

return;

}

lastError.run(name,