Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1914643002: Update to new Webkit additions for custom elements (Closed)

Created:
4 years, 8 months ago by terry
Modified:
4 years, 7 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to latest WebKit changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
terry
4 years, 8 months ago (2016-04-22 19:03:29 UTC) #1
terry
Committed patchset #2 (id:20001) manually as 8f7b8a9d87d63ff164cdeee1be64104b648d8056 (presubmit successful).
4 years, 8 months ago (2016-04-22 19:53:44 UTC) #3
Jacob
lgtm https://codereview.chromium.org/1914643002/diff/20001/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate File tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate (right): https://codereview.chromium.org/1914643002/diff/20001/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate#newcode382 tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate:382: // custom element from JS to Dart. this ...
4 years, 7 months ago (2016-04-25 14:54:13 UTC) #4
Alan Knight
4 years, 7 months ago (2016-04-25 17:40:56 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698