Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 1914613002: Revert of Update V8 to version 5.2.116. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.2.116. (patchset #1 id:1 of https://codereview.chromium.org/1906313003/ ) Reason for revert: https://chromium.googlesource.com/v8/v8/+/8d24472acfaf7e67ca20106cb1f405fc0590c849 causes assertion failures on the Nexus 9: see https://bugs.chromium.org/p/chromium/issues/detail?id=605349#c8 . Original issue's description: > Update V8 to version 5.2.116. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/2b166190..35245d86 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fa24f76ddb9b01ddc62f24b723f589dbbf729a1e Cr-Commit-Position: refs/heads/master@{#389176}

Patch Set 1 #

Patch Set 2 : Fixed merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ken Russell (switch to Gerrit)
Created Revert of Update V8 to version 5.2.116.
4 years, 8 months ago (2016-04-22 18:00:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914613002/1
4 years, 8 months ago (2016-04-22 18:00:41 UTC) #2
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-04-22 18:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914613002/40001
4 years, 8 months ago (2016-04-22 18:29:56 UTC) #6
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-22 18:30:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-22 18:31:08 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa24f76ddb9b01ddc62f24b723f589dbbf729a1e
Cr-Commit-Position: refs/heads/master@{#389176}

Powered by Google App Engine
This is Rietveld 408576698