content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/renderer_host/render_widget_host_view_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 1c9ce1e430de8821450808b9dd533f7c5999f680..63efa447ef2829c86c829b263b5dde893cdf72d3 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -57,6 +57,7 @@

#include "content/common/input/input_event_utils.h"

#include "content/common/input_messages.h"

#include "content/common/site_isolation_policy.h"

+#include "content/common/text_input_state.h"

#include "content/common/view_messages.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_plugin_guest_manager.h"

@@ -1054,7 +1055,7 @@ void RenderWidgetHostViewMac::SetIsLoading(bool is_loading) {

}

void RenderWidgetHostViewMac::TextInputStateChanged(

-const ViewHostMsg_TextInputState_Params& params) {

+ const TextInputState& params) {

if (text_input_type_ != params.type

|| can_compose_inline_ != params.can_compose_inline) {

text_input_type_ = params.type;