content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 3fc47c34c2e7d67e675a880cc84f8f091f5a5679..0d0235834ddbe0b1224750dee71d58c41f2861b7 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -36,6 +36,7 @@

#include "content/common/host_shared_bitmap_manager.h"

#include "content/common/input_messages.h"

#include "content/common/site_isolation_policy.h"

+#include "content/common/text_input_state.h"

#include "content/common/view_messages.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_plugin_guest_manager.h"

@@ -979,10 +980,9 @@ void BrowserPluginGuest::OnTakeFocus(bool reverse) {

new BrowserPluginMsg_AdvanceFocus(browser_plugin_instance_id(), reverse));

}

-void BrowserPluginGuest::OnTextInputStateChanged(

- const ViewHostMsg_TextInputState_Params& params) {

+void BrowserPluginGuest::OnTextInputStateChanged(const TextInputState& params) {

// Save the state of text input so we can restore it on focus.

- last_text_input_state_.reset(new ViewHostMsg_TextInputState_Params(params));

+ last_text_input_state_.reset(new TextInputState(params));

SendTextInputTypeChangedToView(

static_cast<RenderWidgetHostViewBase*>(