content/common/text_input_state.cc - Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/text_input_state.cc

Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/common/text_input_state.h"

	6

	7 namespace content {

	8

	9 TextInputState::TextInputState()

	10 : type(ui::TEXT_INPUT_TYPE_NONE),

	11 mode(ui::TEXT_INPUT_MODE_DEFAULT),

	12 flags(0),

	13 selection_start(0),

	14 selection_end(0),

	15 composition_start(-1),

	16 composition_end(-1),

	17 can_compose_inline(true),

	18 show_ime_if_needed(false),

	19 is_non_ime_change(true) {}
	Charlie Reis 2016/04/22 23:02:38 Does this require a change to BrowserPluginGuest, Does this require a change to BrowserPluginGuest, as we discussed in https://codereview.chromium.org/1894473002/diff/1/content/common/text_input_s... EhsanK 2016/04/25 19:09:00 This initialization is compatible to what we decid Show quoted text On 2016/04/22 23:02:38, Charlie Reis wrote: > Does this require a change to BrowserPluginGuest, as we discussed in > https://codereview.chromium.org/1894473002/diff/1/content/common/text_input_s... This initialization is compatible to what we decided to do last (the least harmful way), which was to However: - The issue in that CL was that we were creating TextInputState() to reset the state for RWHVGuest by calling RWHVGuest::TextInputStateChanged. This was leading to either an uncalled for IPC (which is the case right now), or potential crashes if \|is_non_ime_change\| was true. - That issue is something to resolve in the upcoming CL to land text input state tracking for OOPIF. I actually, think I will not modify <webview> text input tracking at this time until OOPIF lands. BrowserPlugin <webview> might need further fixes before we can implement a similar strategy (crbug.com/602640). Charlie Reis 2016/04/26 06:13:23 Acknowledged. Show quoted text On 2016/04/25 19:09:00, ehsaaan wrote: > On 2016/04/22 23:02:38, Charlie Reis wrote: > > Does this require a change to BrowserPluginGuest, as we discussed in > > > https://codereview.chromium.org/1894473002/diff/1/content/common/text_input_s... > > This initialization is compatible to what we decided to do last (the least > harmful way), which was to However: > - The issue in that CL was that we were creating TextInputState() to reset the > state for RWHVGuest by calling RWHVGuest::TextInputStateChanged. This was > leading to either an uncalled for IPC (which is the case right now), or > potential crashes if \|is_non_ime_change\| was true. > > - That issue is something to resolve in the upcoming CL to land text input > state tracking for OOPIF. I actually, think I will not modify <webview> text > input tracking at this time until OOPIF lands. BrowserPlugin <webview> might > need further fixes before we can implement a similar strategy > (crbug.com/602640). Acknowledged.
	20

	21 TextInputState::TextInputState(const TextInputState& other) = default;

	22

	23 } // namespace content

OLD	NEW

« content/common/text_input_state.h ('K') | « content/common/text_input_state.h ('k') | content/common/view_messages.h » ('j') | content/test/test_render_view_host.h » ('J')