Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 1914583002: Use _downcast and _cast instead of "as" to reduce dart2js output size. (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
Leaf, sra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use _downcast and _cast instead of "as" to reduce dart2js output size. BUG= R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/7fdce7a2f024d5064767d2091c4388b7fc826380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +12 lines, -9 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +12 lines, -9 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Work around "as" check performance in dart2js.
4 years, 8 months ago (2016-04-22 17:16:38 UTC) #2
Leaf
lgtm
4 years, 8 months ago (2016-04-22 18:05:14 UTC) #3
Jacob
4 years, 8 months ago (2016-04-22 18:09:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fdce7a2f024d5064767d2091c4388b7fc826380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698