Fix possible stack overflow in range analysis.

Fix possible stack overflow in range analysis.

Avoid the implicit recursion for range analysis, using a loop with
an explicit stack instead.

BUG=chromium:259452
R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15661

[Dmitry Lomov (no reviews), 2013-07-15 09:12:06]

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.cc
File src/hydrogen-range-analysis.cc (right):

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.c...
src/hydrogen-range-analysis.cc:34: static void TraceRange(const char* msg, ...)
{
nit: Why this change? I liked the original one better, when this trace function
belonged to the class.

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.c...
src/hydrogen-range-analysis.cc:61: for (;;) {
Can we make the terminating condition for this loop more clear? block here is
"inlined" top of the stack, so how about having 'block != NULL' as a loop guard?

[Benedikt Meurer, 2013-07-15 09:17:28]

PTAL

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.cc
File src/hydrogen-range-analysis.cc (right):

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.c...
src/hydrogen-range-analysis.cc:34: static void TraceRange(const char* msg, ...)
{
On 2013/07/15 09:12:06, Dmitry Lomov (chromium) wrote:
> nit: Why this change? I liked the original one better, when this trace
function
> belonged to the class.

Done.

https://codereview.chromium.org/19145002/diff/1/src/hydrogen-range-analysis.c...
src/hydrogen-range-analysis.cc:61: for (;;) {
On 2013/07/15 09:12:06, Dmitry Lomov (chromium) wrote:
> Can we make the terminating condition for this loop more clear? block here is
> "inlined" top of the stack, so how about having 'block != NULL' as a loop
guard?

Done.

[Dmitry Lomov (no reviews), 2013-07-15 09:43:54]

https://codereview.chromium.org/19145002/diff/5001/src/hydrogen-range-analysi...
File src/hydrogen-range-analysis.cc (right):

https://codereview.chromium.org/19145002/diff/5001/src/hydrogen-range-analysi...
src/hydrogen-range-analysis.cc:90: for (int i = dominated_blocks->length(); --i
> 0; ) {
Please no comparison with side effects. Thanks.

[Benedikt Meurer, 2013-07-15 09:49:15]

:-)

https://codereview.chromium.org/19145002/diff/5001/src/hydrogen-range-analysi...
File src/hydrogen-range-analysis.cc (right):

https://codereview.chromium.org/19145002/diff/5001/src/hydrogen-range-analysi...
src/hydrogen-range-analysis.cc:90: for (int i = dominated_blocks->length(); --i
> 0; ) {
On 2013/07/15 09:43:54, Dmitry Lomov (chromium) wrote:
> Please no comparison with side effects. Thanks.

Done.

[Dmitry Lomov (no reviews), 2013-07-15 09:52:57]

lgtm

[Benedikt Meurer, 2013-07-15 09:53:52]

Committed patchset #3 manually as r15661 (presubmit successful).