Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1914473002: [turbofan] Allocate SourcePositionTable inside a Zone. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allocate SourcePositionTable inside a Zone. This also removes the destructor of the class in question, which removed any added decorator from the graph. However the adding of the decorator happens explicitly, so symmetry suggests that removal should also happen explicitly instead of implicitly in the destructor. R=bmeurer@chromium.org Committed: https://crrev.com/8e03bdefc041c03b3028a6b5a50ce791c3b8dbbd Cr-Commit-Position: refs/heads/master@{#35732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M src/compiler/pipeline.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M src/compiler/source-position.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
Benedikt: PTAL. Clemens: FYI.
4 years, 8 months ago (2016-04-22 12:46:48 UTC) #3
Jarin
lgtm
4 years, 8 months ago (2016-04-22 13:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914473002/1
4 years, 8 months ago (2016-04-22 13:54:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 13:57:08 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e03bdefc041c03b3028a6b5a50ce791c3b8dbbd
Cr-Commit-Position: refs/heads/master@{#35732}

Powered by Google App Engine
This is Rietveld 408576698