Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1914463003: Fix bit field access for 64-bit big-endian architectures. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, JaideepBajwa, JoranSiu
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bit field access for 64-bit big-endian architectures. Need to use the kBitFieldSlot rather than kBitFieldOffset for pointer-sized memory accesses. (Fix for "[Atomics] code stubs for atomic operations") R=bmeurer@chromium.org, binji@chromium.org, jarin@chromium.org BUG= Committed: https://crrev.com/fac7361c83dd2b65fdfcb6adbaf4ca2b2b517e9b Cr-Commit-Position: refs/heads/master@{#35767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
MTBrandyberry
PTAL.
4 years, 8 months ago (2016-04-22 21:27:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914463003/1
4 years, 8 months ago (2016-04-22 21:27:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 21:53:49 UTC) #6
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-23 11:58:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914463003/1
4 years, 8 months ago (2016-04-25 13:37:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 14:05:06 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:06:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac7361c83dd2b65fdfcb6adbaf4ca2b2b517e9b
Cr-Commit-Position: refs/heads/master@{#35767}

Powered by Google App Engine
This is Rietveld 408576698