third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h - Issue 1914453002: Replace AllowCrossThreadAccess() + GCed pointers with wrapCrossThreadPersistent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

Issue 1914453002: Replace AllowCrossThreadAccess() + GCed pointers with wrapCrossThreadPersistent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_2

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('K') | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('k') | third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

diff --git a/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h b/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

index 264b5c3c19b30b855e86ab7d7b2317c81bae2d68..f56dd201823c2bd9364cb48b54014e64f77c86b0 100644

--- a/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

+++ b/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

@@ -53,7 +53,7 @@ public:

// The bridge has already disappeared.

return;

}

- m_bridge->getExecutionContext()->postTask(BLINK_FROM_HERE, createCrossThreadTask(&Bridge::runTask, AllowCrossThreadAccess(m_bridge.get()), passed(std::move(task))));

+ m_bridge->getExecutionContext()->postTask(BLINK_FROM_HERE, createCrossThreadTask(&Bridge::runTask, wrapCrossThreadPersistent(m_bridge.get()), passed(std::move(task))));

}

~CrossThreadHolder()