Revert of RenderTextMac: Cache the SkTypeface on the TextRun

Revert of RenderTextMac: Cache the SkTypeface on the TextRun (patchset #4 id:80001 of https://codereview.chromium.org/1907833002/ )

Reason for revert:
Seems to break gfx_unittests on Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384 for more info.

Original issue's description:
> RenderTextMac: Cache the SkTypeface on the TextRun
>
> SkiaTextRenderer::SetFontWithStyle() uses gfx::Font::Derive() which is
> slow. SetFontWithStyle is only used on Mac but, also, there was actually
> never anything to derive on Mac, since RenderTextMac does (on every
> *paint*):
>   CTFontRef = <get font from CTRun>
>   gfx::Font = <wrap CTFontRef>
>   CFFontRef = <unwrap from gfx:Font>  # cheap
>   style = <extract style from CTFontRef>
>   gfx::Font_2 = Derive(apply <style> to gfx::Font)  # A "no-op", but expensive
>
> So remove SkiaTextRenderer::SetFontWithStyle() since nothing needs it.
>
> Then store the SkTypeface on the RenderTextMac TextRun. This saves a
> lookup on each paint and is consistent with RenderTextHarfbuzz.
>
> BUG=605131, 605136
TBR=asvitkine@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605131, 605136
Committed: https://crrev.com/6371bc49fe4c8e605a1b0a98e417e6aea80a5168
Cr-Commit-Position: refs/heads/master@{#389076}

[kjellander_chromium, 2016-04-22 11:23:32]

Created Revert of RenderTextMac: Cache the SkTypeface on the TextRun

[commit-bot: I haz the power, 2016-04-22 11:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914443002/1

[commit-bot: I haz the power, 2016-04-22 11:24:10]

Description was changed from

==========
Revert of RenderTextMac: Cache the SkTypeface on the TextRun (patchset #4
id:80001 of https://codereview.chromium.org/1907833002/ )

Reason for revert:
Seems to break gfx_unittests on Mac10.11 Tests:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...
for more info.

Original issue's description:
> RenderTextMac: Cache the SkTypeface on the TextRun
> 
> SkiaTextRenderer::SetFontWithStyle() uses gfx::Font::Derive() which is
> slow. SetFontWithStyle is only used on Mac but, also, there was actually
> never anything to derive on Mac, since RenderTextMac does (on every
> *paint*):
>   CTFontRef = <get font from CTRun>
>   gfx::Font = <wrap CTFontRef>
>   CFFontRef = <unwrap from gfx:Font>  # cheap
>   style = <extract style from CTFontRef>
>   gfx::Font_2 = Derive(apply <style> to gfx::Font)  # A "no-op", but expensive
> 
> So remove SkiaTextRenderer::SetFontWithStyle() since nothing needs it.
> 
> Then store the SkTypeface on the RenderTextMac TextRun. This saves a
> lookup on each paint and is consistent with RenderTextHarfbuzz.
> 
> BUG=605131, 605136

TBR=asvitkine@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605131, 605136
==========

to

==========
Revert of RenderTextMac: Cache the SkTypeface on the TextRun (patchset #4
id:80001 of https://codereview.chromium.org/1907833002/ )

Reason for revert:
Seems to break gfx_unittests on Mac10.11 Tests:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...
for more info.

Original issue's description:
> RenderTextMac: Cache the SkTypeface on the TextRun
> 
> SkiaTextRenderer::SetFontWithStyle() uses gfx::Font::Derive() which is
> slow. SetFontWithStyle is only used on Mac but, also, there was actually
> never anything to derive on Mac, since RenderTextMac does (on every
> *paint*):
>   CTFontRef = <get font from CTRun>
>   gfx::Font = <wrap CTFontRef>
>   CFFontRef = <unwrap from gfx:Font>  # cheap
>   style = <extract style from CTFontRef>
>   gfx::Font_2 = Derive(apply <style> to gfx::Font)  # A "no-op", but expensive
> 
> So remove SkiaTextRenderer::SetFontWithStyle() since nothing needs it.
> 
> Then store the SkTypeface on the RenderTextMac TextRun. This saves a
> lookup on each paint and is consistent with RenderTextHarfbuzz.
> 
> BUG=605131, 605136

TBR=asvitkine@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605131, 605136
==========

[commit-bot: I haz the power, 2016-04-22 11:24:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:46:17]

Description was changed from

==========
Revert of RenderTextMac: Cache the SkTypeface on the TextRun (patchset #4
id:80001 of https://codereview.chromium.org/1907833002/ )

Reason for revert:
Seems to break gfx_unittests on Mac10.11 Tests:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...
for more info.

Original issue's description:
> RenderTextMac: Cache the SkTypeface on the TextRun
> 
> SkiaTextRenderer::SetFontWithStyle() uses gfx::Font::Derive() which is
> slow. SetFontWithStyle is only used on Mac but, also, there was actually
> never anything to derive on Mac, since RenderTextMac does (on every
> *paint*):
>   CTFontRef = <get font from CTRun>
>   gfx::Font = <wrap CTFontRef>
>   CFFontRef = <unwrap from gfx:Font>  # cheap
>   style = <extract style from CTFontRef>
>   gfx::Font_2 = Derive(apply <style> to gfx::Font)  # A "no-op", but expensive
> 
> So remove SkiaTextRenderer::SetFontWithStyle() since nothing needs it.
> 
> Then store the SkTypeface on the RenderTextMac TextRun. This saves a
> lookup on each paint and is consistent with RenderTextHarfbuzz.
> 
> BUG=605131, 605136

TBR=asvitkine@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605131, 605136
==========

to

==========
Revert of RenderTextMac: Cache the SkTypeface on the TextRun (patchset #4
id:80001 of https://codereview.chromium.org/1907833002/ )

Reason for revert:
Seems to break gfx_unittests on Mac10.11 Tests:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1384

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...
for more info.

Original issue's description:
> RenderTextMac: Cache the SkTypeface on the TextRun
>
> SkiaTextRenderer::SetFontWithStyle() uses gfx::Font::Derive() which is
> slow. SetFontWithStyle is only used on Mac but, also, there was actually
> never anything to derive on Mac, since RenderTextMac does (on every
> *paint*):
>   CTFontRef = <get font from CTRun>
>   gfx::Font = <wrap CTFontRef>
>   CFFontRef = <unwrap from gfx:Font>  # cheap
>   style = <extract style from CTFontRef>
>   gfx::Font_2 = Derive(apply <style> to gfx::Font)  # A "no-op", but expensive
>
> So remove SkiaTextRenderer::SetFontWithStyle() since nothing needs it.
>
> Then store the SkTypeface on the RenderTextMac TextRun. This saves a
> lookup on each paint and is consistent with RenderTextHarfbuzz.
>
> BUG=605131, 605136

TBR=asvitkine@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605131, 605136

Committed: https://crrev.com/6371bc49fe4c8e605a1b0a98e417e6aea80a5168
Cr-Commit-Position: refs/heads/master@{#389076}
==========

[commit-bot: I haz the power, 2016-04-22 19:46:18]

Patchset 1 (id:??) landed as
https://crrev.com/6371bc49fe4c8e605a1b0a98e417e6aea80a5168
Cr-Commit-Position: refs/heads/master@{#389076}