Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2419)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

Issue 1914433002: Assert that AwGLFunctor instances do not leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
index 1166cac0e8ac198fb928488790ee5e6df8bafbf8..f3bfa7f4102e1f72c5b81a75bf7e177c16f0ff22 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
@@ -13,6 +13,7 @@ import android.test.suitebuilder.annotation.LargeTest;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.android_webview.AwContents;
+import org.chromium.android_webview.AwGLFunctor;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
import org.chromium.content.browser.test.util.Criteria;
@@ -237,8 +238,10 @@ public class AwContentsGarbageCollectionTest extends AwTestBase {
return runTestOnUiThreadAndGetResult(new Callable<Boolean>() {
@Override
public Boolean call() {
- int count = AwContents.getNativeInstanceCount();
- return count <= MAX_IDLE_INSTANCES;
+ int count_aw_contents = AwContents.getNativeInstanceCount();
+ int count_aw_functor = AwGLFunctor.getNativeInstanceCount();
+ return count_aw_contents <= MAX_IDLE_INSTANCES
+ && count_aw_functor <= MAX_IDLE_INSTANCES;
}
});
} catch (Exception e) {
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java ('k') | android_webview/native/aw_gl_functor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698