components/offline_pages.gypi - Issue 1914333002: Adding a BUILD file for both gyp and gn for the new background_offlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages.gypi

Issue 1914333002: Adding a BUILD file for both gyp and gn for the new background_offlining (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More CR feedback per fgorski. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages.gypi

diff --git a/components/offline_pages.gypi b/components/offline_pages.gypi

index 05e128348b4814e011df2c3ca00b26968cf97add..65027bfc92c6f19ef48de115f8dc60b768ae2a66 100644

--- a/components/offline_pages.gypi

+++ b/components/offline_pages.gypi

@@ -37,6 +37,26 @@

{

+ # GN: //components/offline_pages/background:background_offliner

+ 'target_name': 'background_offliner',

+ 'type': 'static_library',

+ 'include_dirs': [

+ '..',

+ '../..',

+ ],

+ 'dependencies': [

+ '../base/base.gyp:base',

+ '../net/net.gyp:net',

+ '../url/url.gyp:url_lib',

+ ],

+ 'sources': [

+ 'offline_pages/background/offliner.h',

+ 'offline_pages/background/request_coordinator.cc',

+ 'offline_pages/background/request_coordinator.h',

+ 'offline_pages/background/scheduler.h',

+ ],

+ },

+ {

# GN version: //components/offline_pages:test_support

'target_name': 'offline_pages_test_support',

'type': 'static_library',

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | components/offline_pages/background/BUILD.gn » ('j') | no next file with comments »