Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: components/offline_pages/background/request_coordinator.cc

Issue 1914333002: Adding a BUILD file for both gyp and gn for the new background_offlining (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove commented out lines in the build file. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/background/request_coordinator.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/offline_pages/background/request_coordinator.h"
6
dougarnett 2016/04/27 19:15:35 nit - drop this empty line
Pete Williamson 2016/04/27 21:03:46 There is supposed to be a blank line here. Normal
7 #include "components/offline_pages/background/scheduler.h"
8
9 // TODO: include file with SavePageRequest definition.
10
11 namespace offline_pages {
12
13 // TODO(dougarnett): How to inject Offliner factories and policy objects.
14 RequestCoordinator::RequestCoordinator() {
15 // Do setup as needed.
16 }
17
18 RequestCoordinator::~RequestCoordinator() {
19 // Do cleanup as needed.
20 }
21
22 // Queues |request| to later load and save when system conditions allow.
23 bool RequestCoordinator::SavePageLater(const SavePageRequest& request) {
24 return true;
25 }
26
27 // Starts processing of one or more queued save page later requests.
dougarnett 2016/04/27 19:15:35 might be good to include rest of .h comment wrt co
Pete Williamson 2016/04/27 21:03:46 Done.
28 bool RequestCoordinator::StartProcessing(
29 const ProcessingDoneCallback& callback) {
30 return true;
dougarnett 2016/04/27 19:15:35 false until/unless this will call callback
Pete Williamson 2016/04/27 21:03:46 Done.
31 }
32
33 // Stops the current request processing if active.
34 void RequestCoordinator::StopProcessing() {
35
36 }
37
38 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/request_coordinator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698