Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: components/offline_pages/background/request_coordinator.cc

Issue 1914333002: Adding a BUILD file for both gyp and gn for the new background_offlining (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add .h files to BUILD.gn. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/offline_pages/background/request_coordinator.h"
6
7 // TODO: include file with SavePageRequest definition.
fgorski 2016/04/28 22:18:19 I have that in my patch.
Pete Williamson 2016/04/28 22:30:25 OK, I added your name to the TODO to clear it when
8
9 namespace offline_pages {
10
11 // TODO(dougarnett): How to inject Offliner factories and policy objects.
12 RequestCoordinator::RequestCoordinator() {
13 // Do setup as needed.
14 }
15
16 RequestCoordinator::~RequestCoordinator() {
17 // Do cleanup as needed.
18 }
19
20 // Queues |request| to later load and save when system conditions allow.
fgorski 2016/04/28 22:18:19 don't have to repeat the documentation.
Pete Williamson 2016/04/28 22:30:25 Done.
21 bool RequestCoordinator::SavePageLater(const SavePageRequest& request) {
22 return true;
23 }
24
25 // Starts processing of one or more queued save page later requests.
26 // Returns whether processing was started and that caller should expect
27 // a callback. If processing was already active, returns false.
fgorski 2016/04/28 22:18:19 ditto
Pete Williamson 2016/04/28 22:30:25 Done.
28 bool RequestCoordinator::StartProcessing(
29 const ProcessingDoneCallback& callback) {
30 return false;
31 }
32
33 // Stops the current request processing if active.
fgorski 2016/04/28 22:18:19 ditto
Pete Williamson 2016/04/28 22:30:25 Done.
34 void RequestCoordinator::StopProcessing() {
35
fgorski 2016/04/28 22:18:19 nit: remove empty line
Pete Williamson 2016/04/28 22:30:25 Done.
36 }
37
38 } // namespace offline_pages
OLDNEW
« components/offline_pages.gypi ('K') | « components/offline_pages/background/request_coordinator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698