Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/instrumented_libraries/BUILD.gn

Issue 1914313002: Re-land "Flip remaining non-lkgr linux memory bots to GN." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/buildbot/chromium.memory.fyi.json ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/BUILD.gn
diff --git a/third_party/instrumented_libraries/BUILD.gn b/third_party/instrumented_libraries/BUILD.gn
index 8ca522c2bcfdc0d8c578519074bdf49a4fca3772..6407a3184aa3478d433d8aeccd79e516ea292431 100644
--- a/third_party/instrumented_libraries/BUILD.gn
+++ b/third_party/instrumented_libraries/BUILD.gn
@@ -15,13 +15,17 @@ group("deps") {
deps = [
":prebuilt",
]
+ data = [
+ "$root_out_dir/instrumented_libraries_prebuilt/",
+ ]
}
}
if (prebuilt_available) {
group("prebuilt") {
visibility = [ ":deps" ]
- all_dependent_configs = [ ":prebuilt_link_helper" ]
+
+ # all_dependent_configs = [ ":prebuilt_link_helper" ]
deps = [
":extract_prebuilt_instrumented_libraries",
]
@@ -55,7 +59,6 @@ if (prebuilt_available) {
}
config("prebuilt_link_helper") {
- visibility = [ ":prebuilt" ]
ldflags = [
# Add a relative RPATH entry to Chromium binaries. This puts instrumented
# DSOs before system-installed versions in library search path.
@@ -63,5 +66,8 @@ if (prebuilt_available) {
"-Wl,-z,origin",
]
}
+} else {
+ config("prebuilt_link_helper") {
+ }
}
# TODO(GYP): Support building instrumented libraries from source.
« no previous file with comments | « testing/buildbot/chromium.memory.fyi.json ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698