[Courgette] Fix sorting in QSufSort's split().

courgette/third_party/qsufsort_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/third_party/qsufsort.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cstring>
@@ skipping 20 matching lines @@
   };
 
   for (size_t idx = 0; idx < arraysize(test_cases); ++idx) {
     int len = static_cast<int>(::strlen(test_cases[idx]));
     const unsigned char* s =
         reinterpret_cast<const unsigned char*>(test_cases[idx]);
 
     // Generate the suffix array as I.
     std::vector<int> I(len + 1);
     std::vector<int> V(len + 1);
-    courgette::qsuf::qsufsort<int*>(&I[0], &V[0], s, len);
+    courgette::qsuf::qsufsort<std::vector<int>&>(I, V, s, len);
 
     // Expect that I[] is a permutation of [0, len].
     std::vector<int> I_sorted(I);
     std::sort(I_sorted.begin(), I_sorted.end());
     for (int i = 0; i < len + 1; ++i) {
       EXPECT_EQ(i, I_sorted[i]) << "test_case[" << idx << "]";
     }
 
     // First string must be empty string.
     EXPECT_EQ(len, I[0]) << "test_case[" << idx << "]";
@@ skipping 12 matching lines @@
 TEST(QSufSortTest, Search) {
   // Initialize main string and the suffix array.
   // Positions:          00000000001111111111122222222233333333334444
   //                     01234567890123456789012345678901234567890123
   const char* old_str = "the quick brown fox jumps over the lazy dog.";
   int old_size = static_cast<int>(::strlen(old_str));
   const unsigned char* old_buf =
         reinterpret_cast<const unsigned char*>(old_str);
   std::vector<int> I(old_size + 1);
   std::vector<int> V(old_size + 1);
-  courgette::qsuf::qsufsort<int*>(&I[0], &V[0], old_buf, old_size);
+  courgette::qsuf::qsufsort<std::vector<int>&>(I, V, old_buf, old_size);
 
   // Test queries.
   const struct {
     int exp_pos;  // -1 means "don't care".
     int exp_match_len;
     const char* query_str;
   } test_cases[] = {
     // Entire string.
     {0, 44, "the quick brown fox jumps over the lazy dog."},
     // Empty string.
@@ skipping 42 matching lines @@
       EXPECT_LE(pos, old_size - match_len) << "test_case[" << idx << "]";
       EXPECT_EQ(0, ::memcmp(old_buf + pos, new_buf, match_len))
           << "test_case[" << idx << "]";
     }
     if (test_case.exp_pos >= 0) {
       EXPECT_EQ(test_case.exp_pos, pos) << "test_case[" << idx << "]";
     }
     EXPECT_EQ(test_case.exp_match_len, match_len) << "test_case[" << idx << "]";
   }
 }