SVG <marker> painting TLC

SVG <marker> painting TLC

* Use range-based loop.
* Hide checking for an empty 'viewBox' in LayoutSVGResourceMarker.
* Simplify handling of marker scale due to 'markerUnits'.
* Add some const qualification, reorder forward decls and add missing
  full stops.

Committed: https://crrev.com/d171ededee9ec7d9ac6e382c39023180f3781430
Cr-Commit-Position: refs/heads/master@{#390112}

[fs, 2016-04-27 11:57:17]

Description was changed from

==========
SVG <marker> painting TLC
==========

to

==========
SVG <marker> painting TLC

* Use range-based loop.
* Hide checking for an empty 'viewBox' in LayoutSVGResourceMarker.
* Simplify handling of marker scale due to 'markerUnits'.
* Add some const qualification, reorder forward decls and add missing
  full stops.
==========

[fs, 2016-04-27 13:15:23]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[f(malita), 2016-04-27 14:15:17]

LGTM w/ optional nit.

https://codereview.chromium.org/1914293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
(right):

https://codereview.chromium.org/1914293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp:115:
return markerContentTransformation(transform, referencePoint(), markerScale);
nit: markerContentTransformation concats scale(markerScale) to transform - can
we do that here instead and lose the param?

(actually there isn't much left in markerContentTransformation and this method
is its only client - maybe just merge the two?)

[fs, 2016-04-27 14:27:01]

https://codereview.chromium.org/1914293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
(right):

https://codereview.chromium.org/1914293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp:115:
return markerContentTransformation(transform, referencePoint(), markerScale);
On 2016/04/27 at 14:15:17, f(malita) wrote:
> nit: markerContentTransformation concats scale(markerScale) to transform - can
we do that here instead and lose the param?
> 
> (actually there isn't much left in markerContentTransformation and this method
is its only client - maybe just merge the two?)

Yeah, folding it makes sense. Done.

[fs, 2016-04-27 17:14:12]

The CQ bit was checked by fs@opera.com

[fs, 2016-04-27 17:14:12]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1914293003/#ps20001
(title: "Fold markerContentTransformation.")

[commit-bot: I haz the power, 2016-04-27 17:14:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914293003/20001

[commit-bot: I haz the power, 2016-04-27 17:19:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:10:51]

Patchset 2 (id:??) landed as
https://crrev.com/d171ededee9ec7d9ac6e382c39023180f3781430
Cr-Commit-Position: refs/heads/master@{#390112}

[commit-bot: I haz the power, 2016-04-30 17:50:35]

Description was changed from

==========
SVG <marker> painting TLC

* Use range-based loop.
* Hide checking for an empty 'viewBox' in LayoutSVGResourceMarker.
* Simplify handling of marker scale due to 'markerUnits'.
* Add some const qualification, reorder forward decls and add missing
  full stops.
==========

to

==========
SVG <marker> painting TLC

* Use range-based loop.
* Hide checking for an empty 'viewBox' in LayoutSVGResourceMarker.
* Simplify handling of marker scale due to 'markerUnits'.
* Add some const qualification, reorder forward decls and add missing
  full stops.

Committed: https://crrev.com/d171ededee9ec7d9ac6e382c39023180f3781430
Cr-Commit-Position: refs/heads/master@{#390112}
==========